Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicitly import java flag for kotlin and scala flags #126

Open
ikhoon opened this issue Aug 22, 2022 · 0 comments
Open

Implicitly import java flag for kotlin and scala flags #126

ikhoon opened this issue Aug 22, 2022 · 0 comments

Comments

@ikhoon
Copy link
Contributor

ikhoon commented Aug 22, 2022

kotlin and scala flags are added for configuring the default settings for Kotlin and Scala.
However, they can not activate the common features enabled by java such as publishing, relocation, coverage, and so on.
Even though the kotlin flag is set to a pure Kotlin project, it also needs a java flag.
Otherwise, the project will not be configured or executed as expected.

I think we can assume kotlin and scala is a superset of java flag. So it is convenient to implicitly import java flag for them.

- // Before
- includeWithFlags ':my-kotlin-project', 'java', 'publish', 'relocate', 'kotlin'
+ // After
+ includeWithFlags ':my-kotlin-project', 'kotlin', publish', 'relocate'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant