On master branch, Cmd+Q doesn't quit app, but emits warning instead

[TonalidadeHidrica]

I recently switched from v0.7.0 to master. I recognized that Cmd+Q does not quit the app anymore. This happens not only in my project but also in the example (at least, flex example). Instead, it emits a warning every time I submit the keystroke, apparently related to OS layer:

cargo run --example flex

2021-04-10 13:37:22.456 flex[74291:7719784] +[NSView doCommandBySelector:]: unrecognized selector sent to class 0x7fff885efa08

This happens only in master. In v0.7.0, I can quit the app with Cmd+Q without any warning.

Environment

• druid master (2c5d73c)
• macOS Big Sur 11.2.3 (Intel)

I can provide further environmental information if needed.

[TonalidadeHidrica]

I ran git bisect and found the (possible) cause of the commit: 8e09a6d.

# bad: [2c5d73c8426f90d2a1ede9fdd3b5cb7bee57f108] Add missing derived lens documentation (#1696)
# good: [ed4f9ef0e763d8396ef2fb7facd8ea4ba541c41e] Prepare for 0.7.0
git bisect start '2c5d73c' 'v0.7.0'
# good: [3b902a993623d5ed4e96693d4efbc0ece1fd2333] Fixup changelog links
git bisect good 3b902a993623d5ed4e96693d4efbc0ece1fd2333
# good: [9c361872050cac1aa055bce2e908ad23adc9341d] Relax constraints on who can change focus
git bisect good 9c361872050cac1aa055bce2e908ad23adc9341d
# bad: [0e88d99692ff0163cb0f0838e915b29a25732a77] Fix another clippy lint
git bisect bad 0e88d99692ff0163cb0f0838e915b29a25732a77
# good: [a281a814d1bc61a5169491991367ecb53fd0f383] Unify druid & druid-shell selection types
git bisect good a281a814d1bc61a5169491991367ecb53fd0f383
# bad: [75e83ae5a73fb1da2407eb157580145d833e1caf] updating changelog for on_added WidgetExt method (#1668)
git bisect bad 75e83ae5a73fb1da2407eb157580145d833e1caf
# good: [dde1587267ef0f0f8f4275276aef9288397f8678] Unify druid & druid-shell Movement types
git bisect good dde1587267ef0f0f8f4275276aef9288397f8678
# bad: [8e09a6d5847f83b194dced8c5b9cfa3381b80371] Menus that use data (#1625)
git bisect bad 8e09a6d5847f83b194dced8c5b9cfa3381b80371
# good: [39f4855b0e63ceb8a4c054a4f6ef218145f92ec3] Fix word selection logic
git bisect good 39f4855b0e63ceb8a4c054a4f6ef218145f92ec3
# first bad commit: [8e09a6d5847f83b194dced8c5b9cfa3381b80371] Menus that use data (#1625)

[TonalidadeHidrica]

Actually, the issue is not limited to Cmd+Q, but also Cmd+W which is expected to close the window; moreover, any keystroke with the modifier either Cmd+ or Ctrl+ causes the warning.

[raphlinus]

Repros here too.

[cmyr]

This works as expected for me on 10.15.7, so I think this is a change in macOS?

[lord]

cmd-q in the druid-shell shello example works for me on big sur, until I delete the menubar code — then it stops working. Quit is not actually one of the menu options in that example, which makes this even more weird?

The doCommandBySelector selector being passed in the error case is noop, which I guess is a little unexpected kind of makes sense given how, as noted above, it's emitted for any unbound keyboard shortcut

[cmyr]

Quit isn't an option, but cmd+Q is bound to the 'exit' menu item.

[JarrettBillingsley]

I've only been using druid for a few weeks and thought it was just Like This. I noticed I had to have a menu in order for Cmd+Q to work. Was that not how it used to be?

[cmyr]

Some behaviour has changed.

in 0.7.0, the calc example, which does not get an explicit menu created, still has the default 'application' menu. This is provided by the platform via some mechanism I do not understand. This menu includes the 'Quit' menu item.

In master, calc does not have this menu. The most likely culprit is the menu rework, but I haven't investigated further.

[TonalidadeHidrica]

Just referencing a possibly related issue: andlabs/libui#501 . In this libui issue the "Quit" menu is found in the menu bar, while this druid issue it isn't.

[cmyr]

I've been running into this a bunch lately, and I'm motivated to dig into it soon.

[kud1ing]

Ok, this comes from here:

[cmyr]

thanks.