|
22 | 22 | preferably with the title "Vulnerability in Github LinkedIn/DuaLip - < short summary >". |
23 | 23 |
|
24 | 24 | ## Steps for Creating Pull Request |
25 | | -1. Test build. (./gradlew build) |
26 | | -2. Create a new branch locally. (git branch mybranch) |
27 | | -3. Commit the changes locally. (git commit) |
28 | | -4. **Don't forget to update project.version in build.gradle.** We follow the semantic versioning (major.minor.patch). |
| 25 | +1. Create a new local branch (git branch mybranch) |
| 26 | +2. Make code changes in local branch |
| 27 | +3. **Change major and/or minor version in `version.properties` if necessary**. |
| 28 | + We follow semantic versioning practices (major.minor.patch). |
29 | 29 | * Increment Major for backward incompatible change. |
30 | 30 | * Increment Minor for major function changes. |
31 | | - * Increment Patch for bug fixes. |
32 | | -5. **Also, don't forget to create a corresponding new tag locally and push to the original master.** |
33 | | - * git tag vx.x.x |
34 | | - * git push origin vx.x.x |
| 31 | + * Patch versionining and releases are handled automatically by CI/CD flows. |
| 32 | +4. Commit changes to local branch (git commit) |
| 33 | +5. Test build (./gradlew build) |
35 | 34 | 6. Push local changes to remote branch. (git push -f origin mybranch) |
36 | 35 | 7. Create a new pull request at https://github.com/linkedin/DuaLip/pulls |
37 | | -8. If need to update the pull request, repeat step 2 to 3. |
| 36 | +8. If you need to update the pull request, repeat steps 2 through 6, **excluding step 3**. |
38 | 37 | 9. Getting review and approval. Squash and merge to main branch. |
39 | 38 |
|
40 | 39 | ## Tips for Getting Your Pull Request Accepted |
41 | 40 |
|
42 | 41 | 1. Make sure all new features are tested and the tests pass. |
43 | 42 | 2. Bug fixes must include a test case demonstrating the error that it fixes. |
44 | | -3. Open an issue first and seek advice for your change before submitting a pull request. Large features which have never been discussed are unlikely to be accepted. |
| 43 | +3. Open an issue first and seek advice for your change before submitting a pull request. Large features which have never been discussed are unlikely to be accepted. |
0 commit comments