Skip to content

Commit 24416a4

Browse files
Increase time limit for modal tests (#947)
## Summary <!--- This is a required section; please describe the main purpose of this proposed code change. ---> Modal tests on nvidia gpus failing becuase of time limit errors: https://github.com/linkedin/Liger-Kernel/actions/runs/19472103084/job/55721981739. This PR increases the timeout to 90 mins to fix this. <!--- ## Details This is an optional section; is there anything specific that reviewers should be aware of? ---> ## Testing Done <!--- This is a required section; please describe how this change was tested. ---> <!-- Replace BLANK with your device type. For example, A100-80G-PCIe Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> - Hardware Type: <BLANK> - [ ] run `make test` to ensure correctness - [ ] run `make checkstyle` to ensure code style - [ ] run `make test-convergence` to ensure convergence
1 parent 983b674 commit 24416a4

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

dev/modal/tests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
repo = image.add_local_dir(ROOT_PATH, remote_path=REMOTE_ROOT_PATH)
1515

1616

17-
@app.function(gpu="H100!", image=repo, timeout=60 * 60)
17+
@app.function(gpu="H100!", image=repo, timeout=90 * 60)
1818
def liger_tests():
1919
import subprocess
2020

dev/modal/tests_bwd.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
repo = image.add_local_dir(ROOT_PATH, remote_path=REMOTE_ROOT_PATH)
1515

1616

17-
@app.function(gpu="H100!", image=repo, timeout=60 * 60)
17+
@app.function(gpu="H100!", image=repo, timeout=90 * 60)
1818
def liger_bwd_tests():
1919
import subprocess
2020

0 commit comments

Comments
 (0)