Skip to content

Commit 080722c

Browse files
committed
rename pvt methods
1 parent 5ac359f commit 080722c

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

coral-common/src/main/java/com/linkedin/coral/common/HiveTable.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,20 +156,20 @@ private void checkDaliTable() {
156156
public RelDataType getRowType(RelDataTypeFactory typeFactory) {
157157
// Use two-stage conversion if HiveCoralTable is available
158158
try {
159-
return getRowTypeViaCoralTypeSystem(typeFactory);
159+
return getRowTypeFromCoralType(typeFactory);
160160
} catch (Exception e) {
161161
// Fall back to direct conversion if two-stage conversion fails
162162
LOG.warn("Two-stage type conversion failed for table {}, falling back to direct conversion. Error: {}",
163163
hiveTable.getTableName(), e.getMessage(), e);
164-
return getRowTypeDirectConversion(typeFactory);
164+
return getRowTypeFromHiveType(typeFactory);
165165
}
166166
}
167167

168168
/**
169169
* Two-stage conversion: Hive → Coral → Calcite.
170170
* This is the preferred path when using CoralCatalog.
171171
*/
172-
private RelDataType getRowTypeViaCoralTypeSystem(RelDataTypeFactory typeFactory) {
172+
private RelDataType getRowTypeFromCoralType(RelDataTypeFactory typeFactory) {
173173
// Stage 1: Hive → Coral
174174
CoralDataType coralSchema = getCoralSchema();
175175

@@ -197,7 +197,7 @@ private RelDataType getRowTypeViaCoralTypeSystem(RelDataTypeFactory typeFactory)
197197
* Direct conversion: Hive → Calcite.
198198
* This is the legacy path for backward compatibility.
199199
*/
200-
private RelDataType getRowTypeDirectConversion(RelDataTypeFactory typeFactory) {
200+
private RelDataType getRowTypeFromHiveType(RelDataTypeFactory typeFactory) {
201201
final List<FieldSchema> cols = getColumns();
202202
final List<RelDataType> fieldTypes = new ArrayList<>(cols.size());
203203
final List<String> fieldNames = new ArrayList<>(cols.size());

0 commit comments

Comments
 (0)