Coral-Service: Handle error message for local mode creation failure (#352)

ljfgem · web-flow · commit 0a90624370dc · 2023-02-07T14:08:06.000-08:00
diff --git a/coral-service/src/main/java/com/linkedin/coral/coralservice/controller/TranslationControllerLocal.java b/coral-service/src/main/java/com/linkedin/coral/coralservice/controller/TranslationControllerLocal.java
@@ -44,8 +44,13 @@ public ResponseEntity createInLocalMetastore(@RequestBody String statement) {
           .body("Only queries starting with \"CREATE DATABASE|TABLE|VIEW\" are accepted.\n");
     }
 
-    SessionState.start(conf);
-    run(driver, statement);
+    try {
+      SessionState.start(conf);
+      run(driver, statement);
+    } catch (Throwable t) {
+      final Throwable cause = t.getCause();
+      return ResponseEntity.status(HttpStatus.BAD_REQUEST).body(cause == null ? t.getMessage() : cause.getMessage());
+    }
 
     return ResponseEntity.status(HttpStatus.OK).body("Creation successful\n");
   }

Original file line number	Diff line number	Diff line change
`@@ -44,8 +44,13 @@ public ResponseEntity createInLocalMetastore(@RequestBody String statement) {`
`44`	`44`	`.body("Only queries starting with \"CREATE DATABASE\|TABLE\|VIEW\" are accepted.\n");`
`45`	`45`	`}`
`46`	`46`
`47`		`- SessionState.start(conf);`
`48`		`- run(driver, statement);`
	`47`	`+ try {`
	`48`	`+ SessionState.start(conf);`
	`49`	`+ run(driver, statement);`
	`50`	`+ } catch (Throwable t) {`
	`51`	`+ final Throwable cause = t.getCause();`
	`52`	`+ return ResponseEntity.status(HttpStatus.BAD_REQUEST).body(cause == null ? t.getMessage() : cause.getMessage());`
	`53`	`+ }`
`49`	`54`
`50`	`55`	`return ResponseEntity.status(HttpStatus.OK).body("Creation successful\n");`
`51`	`56`	`}`