glue logic for CoralCatalog in coral-trino

Author: aastha25

coral-hive/src/test/java/com/linkedin/coral/common/IcebergTableConverterTest.java

@@ -62,7 +62,8 @@ private org.apache.iceberg.Table createMockIcebergTable() {
     // TimestampType.withoutZone() represents microsecond precision (6 digits)
     Schema icebergSchema = new Schema(Types.NestedField.required(1, "id", Types.LongType.get()),
         Types.NestedField.required(2, "event_time", Types.TimestampType.withoutZone()),
-        Types.NestedField.optional(3, "name", Types.StringType.get()));
+        Types.NestedField.optional(3, "name", Types.StringType.get()),
+        Types.NestedField.optional(4, "binaryfield", Types.BinaryType.get()));
 
     // Mock the Iceberg Table interface using Mockito
     org.apache.iceberg.Table mockTable = mock(org.apache.iceberg.Table.class);
@@ -99,7 +100,7 @@ public void testIcebergTableWithTimestampPrecision() {
 
     // Check that we have 3 columns: id, event_time, name
     List<RelDataTypeField> fields = relNode.getRowType().getFieldList();
-    assertEquals(fields.size(), 3, "Should have 3 columns");
+    assertEquals(fields.size(), 4, "Should have 3 columns");
 
     // Verify column names
     assertEquals(fields.get(0).getName(), "id");

coral-trino/src/main/java/com/linkedin/coral/trino/rel2trino/DataTypeDerivedSqlCallConverter.java

@@ -1,5 +1,5 @@
 /**
- * Copyright 2022-2024 LinkedIn Corporation. All rights reserved.
+ * Copyright 2022-2025 LinkedIn Corporation. All rights reserved.
  * Licensed under the BSD-2 Clause license.
  * See LICENSE in the project root for license information.
  */
@@ -11,6 +11,7 @@
 import org.apache.calcite.sql.util.SqlShuttle;
 
 import com.linkedin.coral.common.HiveMetastoreClient;
+import com.linkedin.coral.common.catalog.CoralCatalog;
 import com.linkedin.coral.common.functions.Function;
 import com.linkedin.coral.common.transformers.SqlCallTransformers;
 import com.linkedin.coral.common.utils.TypeDerivationUtil;
@@ -48,6 +49,17 @@ public DataTypeDerivedSqlCallConverter(HiveMetastoreClient mscClient, SqlNode to
         new CastOperatorTransformer(typeDerivationUtil), new UnionSqlCallTransformer(typeDerivationUtil));
   }
 
+  public DataTypeDerivedSqlCallConverter(CoralCatalog coralCatalog, SqlNode topSqlNode) {
+    toRelConverter = new HiveToRelConverter(coralCatalog);
+    topSqlNode.accept(new RegisterDynamicFunctionsForTypeDerivation());
+
+    TypeDerivationUtil typeDerivationUtil = new TypeDerivationUtil(toRelConverter.getSqlValidator(), topSqlNode);
+    operatorTransformerList = SqlCallTransformers.of(new FromUtcTimestampOperatorTransformer(typeDerivationUtil),
+        new GenericProjectTransformer(typeDerivationUtil), new NamedStructToCastTransformer(typeDerivationUtil),
+        new ConcatOperatorTransformer(typeDerivationUtil), new SubstrOperatorTransformer(typeDerivationUtil),
+        new CastOperatorTransformer(typeDerivationUtil), new UnionSqlCallTransformer(typeDerivationUtil));
+  }
+
   @Override
   public SqlNode visit(final SqlCall call) {
     return operatorTransformerList.apply((SqlCall) super.visit(call));

coral-trino/src/main/java/com/linkedin/coral/trino/rel2trino/RelToTrinoConverter.java

@@ -1,5 +1,5 @@
 /**
- * Copyright 2017-2024 LinkedIn Corporation. All rights reserved.
+ * Copyright 2017-2025 LinkedIn Corporation. All rights reserved.
  * Licensed under the BSD-2 Clause license.
  * See LICENSE in the project root for license information.
  */
@@ -30,6 +30,7 @@
 
 import com.linkedin.coral.com.google.common.collect.ImmutableList;
 import com.linkedin.coral.common.HiveMetastoreClient;
+import com.linkedin.coral.common.catalog.CoralCatalog;
 import com.linkedin.coral.common.functions.CoralSqlUnnestOperator;
 import com.linkedin.coral.common.functions.FunctionFieldReferenceOperator;
 import com.linkedin.coral.transformers.CoralRelToSqlNodeConverter;
@@ -55,6 +56,7 @@ public class RelToTrinoConverter extends RelToSqlConverter {
    */
   private Map<String, Boolean> configs = new HashMap<>();
   private HiveMetastoreClient _hiveMetastoreClient;
+  private CoralCatalog _coralCatalog;
 
   /**
    * Creates a RelToTrinoConverter.
@@ -65,6 +67,12 @@ public RelToTrinoConverter(HiveMetastoreClient mscClient) {
     _hiveMetastoreClient = mscClient;
   }
 
+  public RelToTrinoConverter(CoralCatalog coralCatalog) {
+    super(CoralRelToSqlNodeConverter.INSTANCE);
+    _coralCatalog = coralCatalog;
+    ;
+  }
+
   /**
    * Creates a RelToTrinoConverter.
    * @param mscClient client interface used to interact with the Hive Metastore service.
@@ -84,9 +92,15 @@ public RelToTrinoConverter(HiveMetastoreClient mscClient, Map<String, Boolean> c
    */
   public String convert(RelNode relNode) {
     SqlNode sqlNode = convertToSqlNode(relNode);
+    SqlNode sqlNodeWithRelDataTypeDerivedConversions;
 
-    SqlNode sqlNodeWithRelDataTypeDerivedConversions =
-        sqlNode.accept(new DataTypeDerivedSqlCallConverter(_hiveMetastoreClient, sqlNode));
+    if (_coralCatalog != null) {
+      sqlNodeWithRelDataTypeDerivedConversions =
+          sqlNode.accept(new DataTypeDerivedSqlCallConverter(_coralCatalog, sqlNode));
+    } else {
+      sqlNodeWithRelDataTypeDerivedConversions =
+          sqlNode.accept(new DataTypeDerivedSqlCallConverter(_hiveMetastoreClient, sqlNode));
+    }
 
     SqlNode sqlNodeWithUDFOperatorConverted =
         sqlNodeWithRelDataTypeDerivedConversions.accept(new CoralToTrinoSqlCallConverter(configs));