Fixing a condition result for disabling TuneIn (#594)

Author: ShubhamGupta29

app/com/linkedin/drelephant/tuning/AbstractFitnessManager.java

@@ -285,7 +285,7 @@ private boolean isTuningEnabled(Integer jobDefinitionId) {
 
       return tuningJobDefinitionNew != null && tuningJobDefinitionNew.tuningEnabled;
     } else {
-      return tuningJobDefinition != null && tuningJobDefinition.tuningEnabled;
+      return tuningJobDefinition.tuningEnabled;
     }
   }
 
@@ -301,6 +301,8 @@ public void disableTuning(JobDefinition jobDefinition, String reason) {
       tuningJobDefinition.tuningEnabled = false;
       tuningJobDefinition.tuningDisabledReason = reason;
       tuningJobDefinition.save();
+      logger.info(String.format("Disabled TuneIn for %d as %s", tuningJobDefinition.job.id,
+          tuningJobDefinition.tuningDisabledReason));
     }
   }
 

app/com/linkedin/drelephant/tuning/hbt/FitnessManagerHBT.java

@@ -191,7 +191,9 @@ protected void checkToDisableTuning(Set<JobDefinition> jobDefinitionSet) {
         if (disableTuningforUserSpecifiedIterations(jobDefinition, numberOfValidSuggestedParamExecution)
             || disableTuningforHeuristicsPassed(jobDefinition, tuningJobExecutionParamSets,
             numberOfValidSuggestedParamExecution)) {
-          logger.debug(" Tuning Disabled for Job " + jobDefinition.id);
+          if (isDebugEnabled) {
+            logger.debug(" Tuning Disabled for Job " + jobDefinition.id);
+          }
         }
       } catch (Exception e) {
         logger.error(" Error while disabling tuneIn for job " + jobDefinition.id, e);
@@ -207,8 +209,9 @@ private boolean disableTuningforHeuristicsPassed(JobDefinition jobDefinition,
     if (areHeuristicsPassed(tuningJobExecutionParamSets)
         && numberOfAppliedSuggestedParamExecution >= MINIMUM_HBT_EXECUTION) {
       disableTuning(jobDefinition, "All Heuristics Passed");
+      return true;
     }
-    return true;
+    return false;
   }
 
   private boolean areHeuristicsPassed(List<TuningJobExecutionParamSet> tuningJobExecutionParamSets) {
@@ -249,10 +252,10 @@ private boolean areAppResultsHaveSeverity(List<AppResult> results) {
         return true;
       }
     }
-    return checkHeuriticsforSeverity(heuristicsWithHighSeverity);
+    return checkHeuristicsForSeverity(heuristicsWithHighSeverity);
   }
 
-  private boolean checkHeuriticsforSeverity(List<String> heuristicsWithHighSeverity) {
+  private boolean checkHeuristicsForSeverity(List<String> heuristicsWithHighSeverity) {
     if (heuristicsWithHighSeverity.size() == 0) {
       logger.debug(" No severe heursitics ");
       return true;