Skip to content

Commit b65b434

Browse files
vikrambohraVikram Bohra
andauthored
Exclude org.apache.hadoop classes from tables-test-fixtures uber jar (#140)
## Summary <!--- HINT: Replace #nnn with corresponding Issue number, if you are fixing an existing issue --> tables test fixtures fat jar ships with a version of OSS hadoop thats incompatible with newer version of li-hadoop (specifically 2.10.0.780). When li-openhouse was upgraded to this version of li-hadoop, unit tests depending on tables test fixtures fat jar started to fail when starting a test hdfs cluster. - [ ] Client-facing API Changes - [ ] Internal API Changes - [x] Bug Fixes - [ ] New Features - [ ] Performance Improvements - [ ] Code Style - [ ] Refactoring - [ ] Documentation - [ ] Tests For all the boxes checked, please include additional details of the changes made in this pull request. ## Testing Done <!--- Check any relevant boxes with "x" --> - [ ] Manually Tested on local docker setup. Please include commands ran, and their output. - [ ] Added new tests for the changes made. - [ ] Updated existing tests to reflect the changes made. - [ ] No tests added or updated. Please explain why. If unsure, please feel free to ask for help. - [x] Some other form of testing like staging or soak time in production. Please explain. Unpacked the jar locally after changes and verified that all hadoop classes are relocated <img width="1431" alt="image" src="https://github.com/user-attachments/assets/6c61ac46-0209-4630-99b7-4b6f14a66736"> For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request. # Additional Information - [ ] Breaking Changes - [ ] Deprecations - [ ] Large PR broken into smaller PRs, and PR plan linked in the description. For all the boxes checked, include additional details of the changes made in this pull request. Co-authored-by: Vikram Bohra <[email protected]>
1 parent b04bb5c commit b65b434

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

tables-test-fixtures/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ shadowJar {
6060
exclude(dependency('ch.qos.logback::'))
6161
exclude(dependency('com.fasterxml.jackson.module::'))
6262
exclude(dependency('com.fasterxml.jackson.core::'))
63+
exclude(dependency('org.apache.hadoop::'))
6364
relocate ('org.yaml.snakeyaml', 'openhouse.relocated.org.yaml.snakeyaml')
6465
relocate ('com.jayway.jsonpath', 'openhouse.relocated.com.jayway.jsonpath')
6566
relocate ('org.json', 'openhouse.relocated.org.json')

0 commit comments

Comments
 (0)