Skip to content

Commit 9a5b8ad

Browse files
committed
Changed PyCoverageTask to use getters for coverage outputs
There was a bug in which the getters for the coverage output file and directory were not being used, resulting in a documentated coverage of 0.
1 parent ac5abf8 commit 9a5b8ad

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

pivy-importer/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ task importRequiredDependencies(type: JavaExec) { task ->
4848
'PyYAML:3.02=PyYAML:3.12',
4949
'setuptools:0.6a2=setuptools:19.1.1', // candidate for removal
5050
'setuptools:0.6c1=setuptools:19.1.1',
51+
'sphinxcontrib-websupport:1.2.0=sphinxcontrib-websupport:1.1.2',
5152
'sphinx_rtd_theme:0.1=sphinx_rtd_theme:0.1.1', // candidate for removal
5253
'sphinx_rtd_theme:0.1.0=sphinx_rtd_theme:0.1.1', // candidate for removal
5354
].join(",")

pygradle-plugin/src/main/groovy/com/linkedin/gradle/python/tasks/PyCoverageTask.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,11 @@ class PyCoverageTask extends PyTestTask {
7575

7676
// If there is no coverage to report, then the htmlDir value will be empty
7777
if (htmlDir != null) {
78-
FileUtils.copyDirectoryToDirectory(project.file(htmlDir), coverageOutputDir)
78+
FileUtils.copyDirectoryToDirectory(project.file(htmlDir), getCoverageOutputDir())
7979
}
8080

8181
CoverageXmlReporter coverageXmlReport = new CoverageXmlReporter(coverage)
82-
coverageReport.text = coverageXmlReport.generateXML()
82+
getCoverageReport().text = coverageXmlReport.generateXML()
8383
super.processResults(execResult)
8484
}
8585

0 commit comments

Comments
 (0)