You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[SPARK-30570][BUILD] Update scalafmt plugin to 1.0.3 with onlyChangedFiles feature
Update the scalafmt plugin to 1.0.3 and use its new onlyChangedFiles feature rather than --diff
Older versions of the plugin either didn't work with scala 2.13, or got rid of the --diff argument and didn't allow for formatting only changed files
The /dev/scalafmt script no longer passes through arbitrary args, instead using the arg to select scala version. The issue here is the plugin name literally contains the scala version, and doesn't appear to have a shorter way to refer to it. If srowen or someone else with better maven-fu has an idea I'm all ears.
Manually, e.g. edited a file and ran
dev/scalafmt
or
dev/scalafmt 2.13
Closesapache#27279 from koeninger/SPARK-30570.
Authored-by: cody koeninger <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 843224e)
Ref: LIHADOOP-54911
This required minor modifications to set the branch for diffing properly (to li-2.3.0) and configure the default Scala version to 2.11.
RB=2208737
BUG=LIHADOOP-54911
G=spark-reviewers
R=mmuralid,vsowrira
A=mmuralid
0 commit comments