Skip to content

Commit d1200b4

Browse files
committed
addressed comments
1 parent 3526f8a commit d1200b4

File tree

2 files changed

+28
-5
lines changed

2 files changed

+28
-5
lines changed

clients/da-vinci-client/src/test/java/com/linkedin/davinci/client/AvroGenericDaVinciClientTest.java

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -506,4 +506,32 @@ public void testSeekToTailWhenNotReady() throws Exception {
506506
} catch (VeniceClientException e) {
507507
}
508508
}
509+
510+
@Test
511+
public void testSeekToTimestampWithException() throws Exception {
512+
// Setup
513+
ClientConfig clientConfig = new ClientConfig(storeName);
514+
AvroGenericSeekableDaVinciClient<Integer, String> dvcClient =
515+
(AvroGenericSeekableDaVinciClient<Integer, String>) setUpSeekableClient(clientConfig, true);
516+
517+
// Mock backend
518+
StoreBackend mockStoreBackend = mock(StoreBackend.class);
519+
// Use reflection to set the private daVinciBackend field
520+
Field backendField = AvroGenericDaVinciClient.class.getDeclaredField("daVinciBackend");
521+
backendField.setAccessible(true);
522+
// Mock the seek method
523+
doReturn(CompletableFuture.completedFuture(null)).when(mockStoreBackend)
524+
.seekToCheckpoint(any(DaVinciSeekCheckpointInfo.class), eq(Optional.empty()));
525+
doReturn(false).when(dvcClient).isReady();
526+
when(dvcClient.getStoreBackend()).thenReturn(mockStoreBackend);
527+
Map<Integer, Long> timestamps = new HashMap<>();
528+
timestamps.put(1, 1000L);
529+
// Verify the exception is propagated
530+
try {
531+
CompletableFuture<Void> future = dvcClient.seekToTimestamps(timestamps);
532+
future.get();
533+
fail("Expected exception to be thrown");
534+
} catch (VeniceClientException e) {
535+
}
536+
}
509537
}

internal/venice-test-common/src/integrationTest/java/com/linkedin/venice/endToEnd/DaVinciClientRecordTransformerTest.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -915,11 +915,6 @@ public void testRecordTransformerDaVinciWithSeeking() throws Exception {
915915
myValueSchema,
916916
dummyRecordTransformerConfig);
917917
List<DefaultPubSubMessage> messages = getDataMessages(storeName, numKeys);
918-
for (DefaultPubSubMessage message: messages) {
919-
System.out.println(
920-
"position: " + message.getPosition() + "ts11 "
921-
+ message.getValue().getProducerMetadata().getMessageTimestamp());
922-
}
923918
DefaultPubSubMessage pubSubMessage = messages.get(4);
924919
VeniceChangeCoordinate changeCoordinate = new VeniceChangeCoordinate(
925920
pubSubMessage.getTopic().getName(),

0 commit comments

Comments
 (0)