Skip to content

Commit 575e933

Browse files
authored
Removing uri-domain-map znode creation from datatree (#74)
Co-authored-by: Rahul Rane <[email protected]>
1 parent c31d262 commit 575e933

File tree

1 file changed

+1
-31
lines changed
  • zookeeper-server/src/main/java/org/apache/zookeeper/server

1 file changed

+1
-31
lines changed

zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java

Lines changed: 1 addition & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -147,13 +147,6 @@ public class DataTree {
147147
/** this will be the string thats stored as a child of /zookeeper */
148148
private static final String configChildZookeeper = configZookeeper.substring(procZookeeper.length() + 1);
149149

150-
/** Root path for storing client URI-domain mappings for X509ZNodeGroupAclProvider. For more information
151-
* about what info is stored under this path please see ZkClientUriDomainMappingHelper documentation. */
152-
private static final String uriDomainMapZookeeper = X509AuthenticationConfig.getInstance().getZnodeGroupAclClientUriDomainMappingRootPath();
153-
154-
/** this will be the string thats stored as a child of /zookeeper */
155-
private static final String uriDomainMapChildZookeeper = uriDomainMapZookeeper.substring(procZookeeper.length() + 1);
156-
157150
/**
158151
* the path trie that keeps track of the quota nodes in this datatree
159152
*/
@@ -340,8 +333,6 @@ public DataTree() {
340333

341334
addConfigNode();
342335

343-
addUriDomainMapNode();
344-
345336
nodeDataSize.set(approximateDataSize());
346337
try {
347338
dataWatches = WatchManagerFactory.createWatchManager();
@@ -376,26 +367,6 @@ public void addConfigNode() {
376367
}
377368
}
378369

379-
/**
380-
* create a /zookeeper/uri-domain-map node for maintaining client-URIs to domain mapping for
381-
* zookeeper
382-
*/
383-
public void addUriDomainMapNode() {
384-
if (!X509AuthenticationConfig.getInstance().isX509ZnodeGroupAclEnabled()) {
385-
return;
386-
}
387-
try {
388-
DataNode zookeeperZnode = nodes.get(procZookeeper);
389-
zookeeperZnode.addChild(uriDomainMapChildZookeeper);
390-
391-
nodes.put(uriDomainMapZookeeper, new DataNode(new byte[0], -1L, new StatPersisted()));
392-
setACL(uriDomainMapZookeeper, ZooDefs.Ids.OPEN_ACL_UNSAFE, -1);
393-
LOG.info("Successfully created client URI-domain root path :{}", uriDomainMapZookeeper);
394-
} catch (Exception e) {
395-
LOG.error("Failed to create client URI-domain mapping node {} :{}", uriDomainMapZookeeper, e);
396-
}
397-
}
398-
399370
/**
400371
* is the path one of the special paths owned by zookeeper.
401372
*
@@ -407,8 +378,7 @@ boolean isSpecialPath(String path) {
407378
return rootZookeeper.equals(path)
408379
|| procZookeeper.equals(path)
409380
|| quotaZookeeper.equals(path)
410-
|| configZookeeper.equals(path)
411-
|| (X509AuthenticationConfig.getInstance().isX509ZnodeGroupAclEnabled() && uriDomainMapZookeeper.equals(path));
381+
|| configZookeeper.equals(path);
412382
}
413383

414384
public static void copyStatPersisted(StatPersisted from, StatPersisted to) {

0 commit comments

Comments
 (0)