You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
forcoalesce, settinginethtool_coalesce.items():
ifsettingisnotNone:
ifisinstance(setting, bool):
setting=int(setting)
configured_coalesce.append(
"%s %s"% (coalesce.replace("_", "-"), setting)
) # ^^^ code about configuring coalesce setting in Network role
Some people suggested to remove the normalization - setting = int(setting). I do not think we should remove if isinstance(setting, bool): setting = int(setting) for coalesce setting. Because the data type for adaptive_rx and adaptive_tx in Network role is bool, see
But In NetworkManager[1], we have to set it to either 0 or 1 when modify the ethtool.coalesce-adaptive-rx and ethtool.coalesce-adaptive-tx setting.
[root@localhost ~]# nmcli connection modify testnic1 ethtool.coalesce-adaptive-rx True
Error: failed to modify ethtool.coalesce-adaptive-rx: 'True' is out of range [0, 4294967295].# Is anything wrong with the error msg?
[root@localhost ~]# nmcli connection modify testnic1 ethtool.coalesce-adaptive-rx 1
Some people suggested to remove the normalization -
setting = int(setting)
. I do not think we should removeif isinstance(setting, bool): setting = int(setting)
for coalesce setting. Because the data type foradaptive_rx
andadaptive_tx
in Network role is bool, seeBut In NetworkManager[1], we have to set it to either 0 or 1 when modify the
ethtool.coalesce-adaptive-rx
andethtool.coalesce-adaptive-tx
setting.[1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/main/src/libnm-core-impl/nm-setting-ethtool.c#L312
The text was updated successfully, but these errors were encountered: