Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leaks from game event handlers #35

Open
JonnyOThan opened this issue Jul 27, 2023 · 1 comment
Open

Memory leaks from game event handlers #35

JonnyOThan opened this issue Jul 27, 2023 · 1 comment

Comments

@JonnyOThan
Copy link

Noticed these in someone's log.

219363 [KSPCF:MemoryLeaks] Removed a onGameSceneLoadRequested GameEvents callback owned by a destroyed HullcamVDSContinued:MuMechModuleHullCameraZoom instance 
219474 [KSPCF:MemoryLeaks] A destroyed HullcamVDSContinued:MovieTime instance is owning a onDockingComplete GameEvents callback. No action has been taken, but unless this mod is relying on this pattern, this is likely a memory leak.
@JonnyOThan
Copy link
Author

HullcamVDSContinued/HullCamera/MovieTime.cs

Line 68 in 8590724

void onDestroy()

This method should be OnDestroy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JonnyOThan