[BUG] init-selkies-config changes causes failure for rootless podman

[zephyros-dev]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

On rootless podman, You cannot use mknod in a user namesapce (rootless container) this is limited by the kernel as mknod is dangerous. Reference
This causes these commands to fail when running the init-selkies-config scripts with rootless podman:

mkdir -pm1777 /dev/input
touch /tmp/selkies_js.log
mknod /dev/input/js0 c 13 0
mknod /dev/input/js1 c 13 1
mknod /dev/input/js2 c 13 2
mknod /dev/input/js3 c 13 3
mknod /dev/input/event1000 c 13 1064
mknod /dev/input/event1001 c 13 1065
mknod /dev/input/event1002 c 13 1066
mknod /dev/input/event1003 c 13 1067
chmod 777 /dev/input/js* /dev/input/event* /tmp/selkies*

The changes in this commit c6c9726#diff-a7a8db2690f0d08ec88ee714f5819667c2e74212250d825b04cf339ff9a9ae5d removed the last command in the scripts. (echo > ....)
As I understood, the scripts will use the return code of the last command that runs it.
In the old scripts, even if the above commands fail, the last command still run successfully, so the return code is still 0 and the above errors are "ignored"
The changes makes the failed command the last command in the script, so the return code of the whole script is changed to 1, which cause the service to fail, which makes the container fails to run

Expected Behavior

While I know the team does not support the podman officially, the fix for this issue (insert a working command at the end of the script, maybe using true?) is quite simple and does not cause much issue as it just preserve the previous behavior of the script

Steps To Reproduce

1. Run a selkies container using rootless podman
2. It will return this error:

s6-rc: warning: unable to start service init-selkies-config: command exited 1

Environment

- OS: Feodra 42
- How docker service was installed: podman

Docker creation

podman run --name test --rm --publish 3000:3000 ghcr.io/linuxserver/baseimage-selkies:debiantrixie

Container logs

s6-rc: warning: unable to start service init-selkies-config: command exited 1

[github-actions]

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

[thelamer]

Easy fix but will not make it until the next waterfall just a heads up.
I will just disable all gamepad logic on a mknod test.

[thelamer]

#102