Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8765 [mB] Redesign frontend: Opener: Image with Aside and detail Project #6076

Closed
mcastro-lqd opened this issue Feb 12, 2025 · 1 comment
Closed
Assignees
Labels
Prio: Medium fixed and released with next scheduled release Type: UX/UI or design issue related to the design

Comments

@mcastro-lqd
Copy link
Contributor

mcastro-lqd commented Feb 12, 2025

URL: https://meinberlin-design-dev.liqd.net/projekte/testing-tile-in-map-upcoming/
user: all
important screensize: Desktop
device & browser: Safari Version 18.1.1 (20619.2.8.11.12) /Chrome
Comment: Can we display the info like the component when the text isn't long enough?

Image
Image

Also the image size seems a bit off:

https://styleguide.berlin.de/patterns/13-vertical_shop-page-herounit-image-with-aside/13-vertical_shop-page-herounit-image-with-aside.html

Image
@CarolingerSeilchenspringer CarolingerSeilchenspringer added Type: UX/UI or design issue related to the design Prio: Medium fixed and released with next scheduled release labels Feb 13, 2025
@hom3mad3 hom3mad3 self-assigned this Feb 18, 2025
@hom3mad3 hom3mad3 changed the title #8765 [mB] Redesign frontend: Opener: Image with Aside and detail Project (Micaela) #8765 [mB] Redesign frontend: Opener: Image with Aside and detail Project Feb 18, 2025
@hom3mad3
Copy link
Contributor

hom3mad3 commented Feb 19, 2025

@mcastro-lqd @Anastasiia3040 I increased the height of the hero to make sure everything fits well and has enough breathing room. The image takes up 50% of the screen width on purpose to give the content more space and balance things out better. Otherwise, there wouldn’t be enough space for the text, and everything would look cramped in our different use cases.

I also went with a custom component instead of the BO one since it was too different, giving us more flexibility.

Image

Image

For the buttons, I know you wanted more space when the description is short. The issue is that adding too much space would affect all variations, even when the content naturally fills the space. My plan is to add a minimum spacing rule to keep things consistent without overdoing it. We could also tweak the design a bit to make sure the buttons feel in place no matter the content size.

Image

cc @sblindow @CarolingerSeilchenspringer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio: Medium fixed and released with next scheduled release Type: UX/UI or design issue related to the design
Projects
None yet
Development

No branches or pull requests

3 participants