fix lints

Signed-off-by: cpanato <[email protected]>

Author: cpanato

.golangci.yml

@@ -87,8 +87,25 @@ issues:
 linters:
   enable-all: true
   disable:
+    - bodyclose
+    - contextcheck
+    - cyclop
     - depguard
+    - exhaustruct
+    - err113
+    - forcetypeassert
     - ireturn
+    - interfacebloat
+    - inamedparam
+    - musttag
+    - nonamedreturns
     - nilnil
     - tagliatelle
     - gomoddirectives
+    - gochecknoglobals
+    - varnamelen
+    - protogetter
+    - gomnd
+    - mnd
+    - wsl
+    - wrapcheck

cmd/flintlock-metrics/main.go

@@ -3,8 +3,9 @@ package main
 import (
 	"os"
 
-	"github.com/liquidmetal-dev/flintlock/internal/command/metrics"
 	"github.com/sirupsen/logrus"
+
+	"github.com/liquidmetal-dev/flintlock/internal/command/metrics"
 )
 
 func main() {

core/application/commands.go

@@ -5,6 +5,9 @@ import (
 	"encoding/base64"
 	"fmt"
 
+	"github.com/sirupsen/logrus"
+	"sigs.k8s.io/yaml"
+
 	"github.com/liquidmetal-dev/flintlock/api/events"
 	"github.com/liquidmetal-dev/flintlock/client/cloudinit"
 	"github.com/liquidmetal-dev/flintlock/client/cloudinit/instance"
@@ -14,8 +17,6 @@ import (
 	"github.com/liquidmetal-dev/flintlock/pkg/defaults"
 	"github.com/liquidmetal-dev/flintlock/pkg/log"
 	"github.com/liquidmetal-dev/flintlock/pkg/validation"
-	"github.com/sirupsen/logrus"
-	"sigs.k8s.io/yaml"
 )
 
 const (
@@ -216,6 +217,4 @@ func (a *app) addMetadataInterface(mvm *models.MicroVM) {
 	}
 	interfaces = append(interfaces, mvm.Spec.NetworkInterfaces...)
 	mvm.Spec.NetworkInterfaces = interfaces
-
-	return
 }

core/application/reconcile.go

@@ -5,6 +5,8 @@ import (
 	"fmt"
 	"time"
 
+	"github.com/sirupsen/logrus"
+
 	"github.com/liquidmetal-dev/flintlock/api/events"
 	"github.com/liquidmetal-dev/flintlock/core/models"
 	"github.com/liquidmetal-dev/flintlock/core/plans"
@@ -13,7 +15,6 @@ import (
 	"github.com/liquidmetal-dev/flintlock/pkg/defaults"
 	"github.com/liquidmetal-dev/flintlock/pkg/log"
 	"github.com/liquidmetal-dev/flintlock/pkg/planner"
-	"github.com/sirupsen/logrus"
 )
 
 const backoffBaseInSeconds = 20

core/errors/errors.go

@@ -17,7 +17,7 @@ var (
 	ErrNoMount                            = errors.New("no image mount point")
 	ErrNoVolumeMount                      = errors.New("no volume mount point")
 	ErrParentIfaceRequiredForMacvtap      = errors.New("a parent network device name is required for macvtap interfaces")
-	ErrParentIfaceRequiredForAttachingTap = errors.New("a parent network device name is required for attaching a TAP interface")
+	ErrParentIfaceRequiredForAttachingTap = errors.New("a parent network device name is required for attaching a TAP interface") //nolint: lll // that is okay
 	ErrGuestDeviceNameRequired            = errors.New("a guest device name is required")
 	ErrUnsupportedIfaceType               = errors.New("unsupported network interface type")
 	ErrIfaceNotFound                      = errors.New("network interface not found")
@@ -41,7 +41,7 @@ type IncorrectVMIDFormatError struct {
 
 // Error returns the error message.
 func (e IncorrectVMIDFormatError) Error() string {
-	return fmt.Sprintf("unexpected vmid format: %s", e.ActualID)
+	return "unexpected vmid format: " + e.ActualID
 }
 
 func NewErrUnsupportedInterface(ifaceType string) UnsupportedInterfaceError {
@@ -136,7 +136,7 @@ type notSupportedError struct {
 
 // Error returns the error message.
 func (e notSupportedError) Error() string {
-	return fmt.Sprintf("%s is not supported", e.unsupported)
+	return e.unsupported + "is not supported"
 }
 
 // IsNotSupported tests an error to see if its a not supported error.

core/plans/types.go

@@ -1,8 +1,9 @@
 package plans
 
 import (
-	"github.com/liquidmetal-dev/flintlock/core/ports"
 	"github.com/spf13/afero"
+
+	"github.com/liquidmetal-dev/flintlock/core/ports"
 )
 
 // Providers input is a type to be used as input to plans.

core/steps/cloudinit/disk_mount.go

@@ -119,7 +119,7 @@ func (s *diskMountStep) Do(ctx context.Context) ([]planner.Procedure, error) {
 	return nil, nil
 }
 
-func (s *diskMountStep) Verify(ctx context.Context) error {
+func (s *diskMountStep) Verify(_ context.Context) error {
 	return nil
 }
 

core/steps/event/publish.go

@@ -29,7 +29,7 @@ func (s *eventPublish) Name() string {
 	return "event_publish"
 }
 
-func (s *eventPublish) ShouldDo(ctx context.Context) (bool, error) {
+func (s *eventPublish) ShouldDo(_ context.Context) (bool, error) {
 	return true, nil
 }
 
@@ -47,6 +47,6 @@ func (s *eventPublish) Do(ctx context.Context) ([]planner.Procedure, error) {
 	return nil, nil
 }
 
-func (s *eventPublish) Verify(ctx context.Context) error {
+func (s *eventPublish) Verify(_ context.Context) error {
 	return nil
 }

core/steps/microvm/create.go

@@ -63,6 +63,6 @@ func (s *createStep) Do(ctx context.Context) ([]planner.Procedure, error) {
 	return nil, nil
 }
 
-func (s *createStep) Verify(ctx context.Context) error {
+func (s *createStep) Verify(_ context.Context) error {
 	return nil
 }

core/steps/microvm/delete.go

@@ -60,6 +60,6 @@ func (s *deleteStep) Do(ctx context.Context) ([]planner.Procedure, error) {
 	return nil, nil
 }
 
-func (s *deleteStep) Verify(ctx context.Context) error {
+func (s *deleteStep) Verify(_ context.Context) error {
 	return nil
 }