Fix class reloading issues (decidim#1749)

* Simplify "super" chain in `NeedsAuthorization`

I think it's better that each module including `NeedsAuthorization`
specifies the base ability class, instead of providing a default and
then overriding it.

* Explicit base ApplicationController class

Otherwise we can get into code reloading issues. Better be explicit.

Author: deivid-rodriguez

decidim-admin/app/controllers/decidim/admin/exports_controller.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Admin
     # This controller allows admins to manage proposals in a participatory process.
-    class ExportsController < ApplicationController
+    class ExportsController < Decidim::Admin::ApplicationController
       include Concerns::ParticipatoryProcessAdmin
       include Decidim::FeaturePathHelper
 

decidim-admin/app/controllers/decidim/admin/newsletters_controller.rb

@@ -4,7 +4,7 @@ module Decidim
   module Admin
     # Controller that allows managing newsletters.
     #
-    class NewslettersController < ApplicationController
+    class NewslettersController < Decidim::Admin::ApplicationController
       def index
         authorize! :index, Newsletter
         @newsletters = collection.order(Newsletter.arel_table[:created_at].desc)

decidim-admin/app/controllers/decidim/admin/user_groups_controller.rb

@@ -4,7 +4,7 @@ module Decidim
   module Admin
     # Controller that allows managing user groups at the admin panel.
     #
-    class UserGroupsController < ApplicationController
+    class UserGroupsController < Decidim::Admin::ApplicationController
       layout "decidim/admin/users"
 
       def index

decidim-api/app/controllers/decidim/api/application_controller.rb

@@ -8,6 +8,12 @@ class ApplicationController < ::DecidimController
       include NeedsOrganization
       include NeedsAuthorization
       include ImpersonateUsers
+
+      # Overwrites `cancancan`'s method to point to the correct ability class,
+      # since the gem expects the ability class to be in the root namespace.
+      def current_ability_klass
+        Decidim::Abilities::BaseAbility
+      end
     end
   end
 end

decidim-core/app/controllers/concerns/decidim/devise_controllers.rb

@@ -26,5 +26,11 @@ module DeviseControllers
 
       layout "layouts/decidim/application"
     end
+
+    # Overwrites `cancancan`'s method to point to the correct ability class,
+    # since the gem expects the ability class to be in the root namespace.
+    def current_ability_klass
+      Decidim::Abilities::BaseAbility
+    end
   end
 end

decidim-core/app/controllers/concerns/decidim/needs_authorization.rb

@@ -21,10 +21,6 @@ def current_ability
         @current_ability ||= current_ability_klass.new(current_user, ability_context)
       end
 
-      def current_ability_klass
-        Decidim::Abilities::BaseAbility
-      end
-
       def ability_context
         {
           current_settings: try(:current_settings),

decidim-core/app/controllers/decidim/application_controller.rb

@@ -46,5 +46,11 @@ def user_not_authorized_path
     def add_vary_header
       response.headers["Vary"] = "Accept"
     end
+
+    # Overwrites `cancancan`'s method to point to the correct ability class,
+    # since the gem expects the ability class to be in the root namespace.
+    def current_ability_klass
+      Decidim::Abilities::BaseAbility
+    end
   end
 end

decidim-core/app/controllers/decidim/errors_controller.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Decidim
-  class ErrorsController < ApplicationController
+  class ErrorsController < Decidim::ApplicationController
     skip_authorization_check
 
     def not_found

decidim-proposals/spec/controllers/concerns/orderable_spec.rb

@@ -4,7 +4,7 @@
 
 module Decidim
   module Proposals
-    class OrderableFakeController < ApplicationController
+    class OrderableFakeController < Decidim::ApplicationController
       include Orderable
     end