From 673d561cc676791cbd7b25d449b15acecf18ab47 Mon Sep 17 00:00:00 2001 From: Neelanjan Manna Date: Tue, 17 May 2022 10:29:50 +0530 Subject: [PATCH 1/5] updated gcp-vm-disk-loss pipeline to remove device names Signed-off-by: Neelanjan Manna --- .github/workflows/gcp-experiment-pipeline.yml | 5 ++--- .github/workflows/nightly-gcp-experiment-pipeline.yml | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/gcp-experiment-pipeline.yml b/.github/workflows/gcp-experiment-pipeline.yml index dfcf0d255..4c2a5626c 100644 --- a/.github/workflows/gcp-experiment-pipeline.yml +++ b/.github/workflows/gcp-experiment-pipeline.yml @@ -176,8 +176,8 @@ jobs: gcloud compute instances create litmus-e2e-vm-${{ github.run_number }} \ --machine-type=f1-micro \ --zone=us-central1-a \ - --create-disk name=litmus-e2e-first-disk-${{ github.run_number }},size=1GB,device-name=litmus-e2e-first-disk-${{ github.run_number }} \ - --create-disk name=litmus-e2e-second-disk-${{ github.run_number }},size=1GB,device-name=litmus-e2e-second-disk-${{ github.run_number }} + --create-disk name=litmus-e2e-first-disk-${{ github.run_number }},size=1GB \ + --create-disk name=litmus-e2e-second-disk-${{ github.run_number }},size=1GB - name: Litmus Infra Setup if: always() @@ -192,7 +192,6 @@ jobs: GCP_PROJECT_ID: ${{ secrets.GCP_PROJECT_ID }} DISK_VOLUME_NAMES: "litmus-e2e-first-disk-${{ github.run_number }},litmus-e2e-second-disk-${{ github.run_number }}" DISK_ZONES: "us-central1-a,us-central1-a" - DEVICE_NAMES: "litmus-e2e-first-disk-${{ github.run_number }},litmus-e2e-second-disk-${{ github.run_number }}" EXPERIMENT_IMAGE: "${{ github.event.inputs.experimentImage }}" EXPERIMENT_IMAGE_PULL_POLICY: "${{ github.event.inputs.experimentImagePullPolicy }}" CHAOS_NAMESPACE: "${{ github.event.inputs.chaosNamespace }}" diff --git a/.github/workflows/nightly-gcp-experiment-pipeline.yml b/.github/workflows/nightly-gcp-experiment-pipeline.yml index e2ae5d684..0f5d19233 100644 --- a/.github/workflows/nightly-gcp-experiment-pipeline.yml +++ b/.github/workflows/nightly-gcp-experiment-pipeline.yml @@ -162,8 +162,8 @@ jobs: gcloud compute instances create litmus-e2e-vm-${{ github.run_number }} \ --machine-type=f1-micro \ --zone=us-central1-a \ - --create-disk name=litmus-e2e-first-disk-${{ github.run_number }},size=1GB,device-name=litmus-e2e-first-disk-${{ github.run_number }} \ - --create-disk name=litmus-e2e-second-disk-${{ github.run_number }},size=1GB,device-name=litmus-e2e-second-disk-${{ github.run_number }} + --create-disk name=litmus-e2e-first-disk-${{ github.run_number }},size=1GB \ + --create-disk name=litmus-e2e-second-disk-${{ github.run_number }},size=1GB - name: Litmus Infra Setup if: always() @@ -175,7 +175,6 @@ jobs: GCP_PROJECT_ID: ${{ secrets.GCP_PROJECT_ID }} DISK_VOLUME_NAMES: "litmus-e2e-first-disk-${{ github.run_number }},litmus-e2e-second-disk-${{ github.run_number }}" DISK_ZONES: "us-central1-a,us-central1-a" - DEVICE_NAMES: "litmus-e2e-first-disk-${{ github.run_number }},litmus-e2e-second-disk-${{ github.run_number }}" run: make gcp-vm-disk-loss - name: Delete the VM Instance and target Disk Volumes From 0836d1180fad3ef57db5fdb844eca34beee4b243 Mon Sep 17 00:00:00 2001 From: Neelanjan Manna Date: Tue, 17 May 2022 10:35:36 +0530 Subject: [PATCH 2/5] updated environment and install files to remove device names Signed-off-by: Neelanjan Manna --- pkg/environment/environment.go | 1 - pkg/install.go | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/pkg/environment/environment.go b/pkg/environment/environment.go index 41f0413d0..915dd5529 100644 --- a/pkg/environment/environment.go +++ b/pkg/environment/environment.go @@ -38,7 +38,6 @@ func GetENV(testDetails *types.TestDetails, expName, engineName string) { testDetails.InstanceZones = Getenv("INSTANCE_ZONES", "") testDetails.DiskVolumeNames = Getenv("DISK_VOLUME_NAMES", "") testDetails.DiskZones = Getenv("DISK_ZONES", "") - testDetails.DeviceNames = Getenv("DEVICE_NAMES", "") testDetails.VMIds = Getenv("APP_VM_MOIDS", "") testDetails.Region = Getenv("REGION", "us-west-1") testDetails.UpdateWebsite = Getenv("UPDATE_WEBSITE", "false") diff --git a/pkg/install.go b/pkg/install.go index 0bfa08efe..1b1eb543e 100644 --- a/pkg/install.go +++ b/pkg/install.go @@ -334,8 +334,7 @@ func setEngineVar(chaosEngine *v1alpha1.ChaosEngine, testsDetails *types.TestDet case "gcp-vm-disk-loss": envDetails.SetEnv("GCP_PROJECT_ID", testsDetails.GCPProjectID). SetEnv("DISK_VOLUME_NAMES", testsDetails.DiskVolumeNames). - SetEnv("DISK_ZONES", testsDetails.DiskZones). - SetEnv("DEVICE_NAMES", testsDetails.DeviceNames) + SetEnv("DISK_ZONES", testsDetails.DiskZones) case "vm-poweroff": envDetails.SetEnv("APP_VM_MOIDS", testsDetails.VMIds) case "process-kill": From 41456d83c02106a24e774b4ba6f566bfe2e28c9b Mon Sep 17 00:00:00 2001 From: Neelanjan Manna Date: Tue, 17 May 2022 10:41:05 +0530 Subject: [PATCH 3/5] updated zones to us-east1-b Signed-off-by: Neelanjan Manna --- .github/workflows/gcp-experiment-pipeline.yml | 12 ++++++------ .../workflows/nightly-gcp-experiment-pipeline.yml | 12 ++++++------ 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/gcp-experiment-pipeline.yml b/.github/workflows/gcp-experiment-pipeline.yml index 4c2a5626c..f604ebf83 100644 --- a/.github/workflows/gcp-experiment-pipeline.yml +++ b/.github/workflows/gcp-experiment-pipeline.yml @@ -70,7 +70,7 @@ jobs: run: | gcloud compute instances create litmus-e2e-first-vm-${{ github.run_number }} litmus-e2e-second-vm-${{ github.run_number }} \ --machine-type=f1-micro \ - --zone=us-central1-a + --zone=us-east1-b - name: Litmus Infra Setup if: always() @@ -84,7 +84,7 @@ jobs: env: GCP_PROJECT_ID: ${{ secrets.GCP_PROJECT_ID }} VM_INSTANCE_NAMES: "litmus-e2e-first-vm-${{ github.run_number }},litmus-e2e-second-vm-${{ github.run_number }}" - INSTANCE_ZONES: "us-central1-a,us-central1-a" + INSTANCE_ZONES: "us-east1-b,us-east1-b" EXPERIMENT_IMAGE: "${{ github.event.inputs.experimentImage }}" EXPERIMENT_IMAGE_PULL_POLICY: "${{ github.event.inputs.experimentImagePullPolicy }}" CHAOS_NAMESPACE: "${{ github.event.inputs.chaosNamespace }}" @@ -94,7 +94,7 @@ jobs: if: always() run: | gcloud compute instances delete litmus-e2e-first-vm-${{ github.run_number }} litmus-e2e-second-vm-${{ github.run_number }} \ - --zone=us-central1-a \ + --zone=us-east1-b \ --quiet - name: "[Debug]: check chaos resources" @@ -175,7 +175,7 @@ jobs: run: | gcloud compute instances create litmus-e2e-vm-${{ github.run_number }} \ --machine-type=f1-micro \ - --zone=us-central1-a \ + --zone=us-east1-b \ --create-disk name=litmus-e2e-first-disk-${{ github.run_number }},size=1GB \ --create-disk name=litmus-e2e-second-disk-${{ github.run_number }},size=1GB @@ -191,7 +191,7 @@ jobs: env: GCP_PROJECT_ID: ${{ secrets.GCP_PROJECT_ID }} DISK_VOLUME_NAMES: "litmus-e2e-first-disk-${{ github.run_number }},litmus-e2e-second-disk-${{ github.run_number }}" - DISK_ZONES: "us-central1-a,us-central1-a" + DISK_ZONES: "us-east1-b,us-east1-b" EXPERIMENT_IMAGE: "${{ github.event.inputs.experimentImage }}" EXPERIMENT_IMAGE_PULL_POLICY: "${{ github.event.inputs.experimentImagePullPolicy }}" CHAOS_NAMESPACE: "${{ github.event.inputs.chaosNamespace }}" @@ -201,7 +201,7 @@ jobs: if: always() run: | gcloud compute instances delete litmus-e2e-vm-${{ github.run_number }} \ - --zone=us-central1-a \ + --zone=us-east1-b \ --delete-disks=all \ --quiet diff --git a/.github/workflows/nightly-gcp-experiment-pipeline.yml b/.github/workflows/nightly-gcp-experiment-pipeline.yml index 0f5d19233..c8cab1f85 100644 --- a/.github/workflows/nightly-gcp-experiment-pipeline.yml +++ b/.github/workflows/nightly-gcp-experiment-pipeline.yml @@ -62,7 +62,7 @@ jobs: run: | gcloud compute instances create litmus-e2e-first-vm-${{ github.run_number }} litmus-e2e-second-vm-${{ github.run_number }} \ --machine-type=f1-micro \ - --zone=us-central1-a + --zone=us-east1-b - name: Litmus Infra Setup if: always() @@ -73,14 +73,14 @@ jobs: env: GCP_PROJECT_ID: ${{ secrets.GCP_PROJECT_ID }} VM_INSTANCE_NAMES: "litmus-e2e-first-vm-${{ github.run_number }},litmus-e2e-second-vm-${{ github.run_number }}" - INSTANCE_ZONES: "us-central1-a,us-central1-a" + INSTANCE_ZONES: "us-east1-b,us-east1-b" run: make gcp-vm-instance-stop - name: Delete target GCP VM Instances if: always() run: | gcloud compute instances delete litmus-e2e-first-vm-${{ github.run_number }} litmus-e2e-second-vm-${{ github.run_number }} \ - --zone=us-central1-a \ + --zone=us-east1-b \ --quiet - name: "[Debug]: check chaos resources" @@ -161,7 +161,7 @@ jobs: run: | gcloud compute instances create litmus-e2e-vm-${{ github.run_number }} \ --machine-type=f1-micro \ - --zone=us-central1-a \ + --zone=us-east1-b \ --create-disk name=litmus-e2e-first-disk-${{ github.run_number }},size=1GB \ --create-disk name=litmus-e2e-second-disk-${{ github.run_number }},size=1GB @@ -174,14 +174,14 @@ jobs: env: GCP_PROJECT_ID: ${{ secrets.GCP_PROJECT_ID }} DISK_VOLUME_NAMES: "litmus-e2e-first-disk-${{ github.run_number }},litmus-e2e-second-disk-${{ github.run_number }}" - DISK_ZONES: "us-central1-a,us-central1-a" + DISK_ZONES: "us-east1-b,us-east1-b" run: make gcp-vm-disk-loss - name: Delete the VM Instance and target Disk Volumes if: always() run: | gcloud compute instances delete litmus-e2e-vm-${{ github.run_number }} \ - --zone=us-central1-a \ + --zone=us-east1-b \ --delete-disks=all \ --quiet From 4245b73dc28079ceae10b336c00db84938ee410d Mon Sep 17 00:00:00 2001 From: Neelanjan Manna Date: Wed, 18 May 2022 13:40:17 +0530 Subject: [PATCH 4/5] updated TestDetails to remove DeviceNames Signed-off-by: Neelanjan Manna --- pkg/types/types.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/types/types.go b/pkg/types/types.go index 71bfb2185..f2639860c 100644 --- a/pkg/types/types.go +++ b/pkg/types/types.go @@ -47,7 +47,6 @@ type TestDetails struct { InstanceZones string DiskVolumeNames string DiskZones string - DeviceNames string VMIds string Region string Lib string From 1308581f4f81332050be2421a0783b6e0f35cfda Mon Sep 17 00:00:00 2001 From: Neelanjan Manna Date: Thu, 2 Jun 2022 16:17:15 +0530 Subject: [PATCH 5/5] added zone as secret Signed-off-by: Neelanjan Manna --- .github/workflows/gcp-experiment-pipeline.yml | 12 ++++++------ .github/workflows/m-agent-experiment-pipeline.yml | 10 +++++----- .../workflows/nightly-gcp-experiment-pipeline.yml | 12 ++++++------ .../nightly-m-agent-experiment-pipeline.yaml | 10 +++++----- 4 files changed, 22 insertions(+), 22 deletions(-) diff --git a/.github/workflows/gcp-experiment-pipeline.yml b/.github/workflows/gcp-experiment-pipeline.yml index f604ebf83..5054a0089 100644 --- a/.github/workflows/gcp-experiment-pipeline.yml +++ b/.github/workflows/gcp-experiment-pipeline.yml @@ -70,7 +70,7 @@ jobs: run: | gcloud compute instances create litmus-e2e-first-vm-${{ github.run_number }} litmus-e2e-second-vm-${{ github.run_number }} \ --machine-type=f1-micro \ - --zone=us-east1-b + --zone=${{ secrets.GCP_ZONE }} - name: Litmus Infra Setup if: always() @@ -84,7 +84,7 @@ jobs: env: GCP_PROJECT_ID: ${{ secrets.GCP_PROJECT_ID }} VM_INSTANCE_NAMES: "litmus-e2e-first-vm-${{ github.run_number }},litmus-e2e-second-vm-${{ github.run_number }}" - INSTANCE_ZONES: "us-east1-b,us-east1-b" + INSTANCE_ZONES: "${{ secrets.GCP_ZONE }},${{ secrets.GCP_ZONE }}" EXPERIMENT_IMAGE: "${{ github.event.inputs.experimentImage }}" EXPERIMENT_IMAGE_PULL_POLICY: "${{ github.event.inputs.experimentImagePullPolicy }}" CHAOS_NAMESPACE: "${{ github.event.inputs.chaosNamespace }}" @@ -94,7 +94,7 @@ jobs: if: always() run: | gcloud compute instances delete litmus-e2e-first-vm-${{ github.run_number }} litmus-e2e-second-vm-${{ github.run_number }} \ - --zone=us-east1-b \ + --zone=${{ secrets.GCP_ZONE }} \ --quiet - name: "[Debug]: check chaos resources" @@ -175,7 +175,7 @@ jobs: run: | gcloud compute instances create litmus-e2e-vm-${{ github.run_number }} \ --machine-type=f1-micro \ - --zone=us-east1-b \ + --zone=${{ secrets.GCP_ZONE }} \ --create-disk name=litmus-e2e-first-disk-${{ github.run_number }},size=1GB \ --create-disk name=litmus-e2e-second-disk-${{ github.run_number }},size=1GB @@ -191,7 +191,7 @@ jobs: env: GCP_PROJECT_ID: ${{ secrets.GCP_PROJECT_ID }} DISK_VOLUME_NAMES: "litmus-e2e-first-disk-${{ github.run_number }},litmus-e2e-second-disk-${{ github.run_number }}" - DISK_ZONES: "us-east1-b,us-east1-b" + DISK_ZONES: "${{ secrets.GCP_ZONE }},${{ secrets.GCP_ZONE }}" EXPERIMENT_IMAGE: "${{ github.event.inputs.experimentImage }}" EXPERIMENT_IMAGE_PULL_POLICY: "${{ github.event.inputs.experimentImagePullPolicy }}" CHAOS_NAMESPACE: "${{ github.event.inputs.chaosNamespace }}" @@ -201,7 +201,7 @@ jobs: if: always() run: | gcloud compute instances delete litmus-e2e-vm-${{ github.run_number }} \ - --zone=us-east1-b \ + --zone=${{ secrets.GCP_ZONE }} \ --delete-disks=all \ --quiet diff --git a/.github/workflows/m-agent-experiment-pipeline.yml b/.github/workflows/m-agent-experiment-pipeline.yml index cd30e8316..e043a8e2e 100644 --- a/.github/workflows/m-agent-experiment-pipeline.yml +++ b/.github/workflows/m-agent-experiment-pipeline.yml @@ -35,7 +35,7 @@ jobs: run: | gcloud compute instances create litmus-e2e-m-agent-vm-${{ github.run_number }} \ --machine-type=f1-micro \ - --zone=us-east4-c \ + --zone=${{ secrets.GCP_ZONE }} \ --metadata=startup-script='#! /bin/bash apt update apt -y install apache2 @@ -45,7 +45,7 @@ jobs: - name: Get Agent Endpoint and Auth Token if: always() id: get-credentials - run: gcloud compute ssh --zone us-east4-c litmus-e2e-m-agent-vm-${{ github.run_number }} -- 'm-agent --get-token --token-expiry-duration 30m' > token.txt + run: gcloud compute ssh --zone ${{ secrets.GCP_ZONE }} litmus-e2e-m-agent-vm-${{ github.run_number }} -- 'm-agent --get-token --token-expiry-duration 30m' > token.txt - uses: actions/upload-artifact@v3 with: @@ -55,12 +55,12 @@ jobs: - name: Get main PID of the Apache Service as Target Process if: always() id: get-apache-target-process - run: echo "::set-output name=pid1::$(gcloud compute ssh --zone us-east4-c litmus-e2e-m-agent-vm-${{ github.run_number }} -- 'systemctl show --property MainPID --value apache2')" + run: echo "::set-output name=pid1::$(gcloud compute ssh --zone ${{ secrets.GCP_ZONE }} litmus-e2e-m-agent-vm-${{ github.run_number }} -- 'systemctl show --property MainPID --value apache2')" - name: Get main PID of the Apache Service as Target Process if: always() id: get-crond-target-process - run: echo "::set-output name=pid2::$(gcloud compute ssh --zone us-east4-c litmus-e2e-m-agent-vm-${{ github.run_number }} -- 'systemctl show --property MainPID --value cron')" + run: echo "::set-output name=pid2::$(gcloud compute ssh --zone ${{ secrets.GCP_ZONE }} litmus-e2e-m-agent-vm-${{ github.run_number }} -- 'systemctl show --property MainPID --value cron')" Process_Kill_Serial_Test: needs: Setup_m-agent @@ -243,5 +243,5 @@ jobs: if: always() run: | gcloud compute instances delete litmus-e2e-m-agent-vm-${{ github.run_number }} \ - --zone=us-east4-c \ + --zone=${{ secrets.GCP_ZONE }} \ --quiet \ No newline at end of file diff --git a/.github/workflows/nightly-gcp-experiment-pipeline.yml b/.github/workflows/nightly-gcp-experiment-pipeline.yml index c8cab1f85..36e9ea87f 100644 --- a/.github/workflows/nightly-gcp-experiment-pipeline.yml +++ b/.github/workflows/nightly-gcp-experiment-pipeline.yml @@ -62,7 +62,7 @@ jobs: run: | gcloud compute instances create litmus-e2e-first-vm-${{ github.run_number }} litmus-e2e-second-vm-${{ github.run_number }} \ --machine-type=f1-micro \ - --zone=us-east1-b + --zone=${{ secrets.GCP_ZONE }} - name: Litmus Infra Setup if: always() @@ -73,14 +73,14 @@ jobs: env: GCP_PROJECT_ID: ${{ secrets.GCP_PROJECT_ID }} VM_INSTANCE_NAMES: "litmus-e2e-first-vm-${{ github.run_number }},litmus-e2e-second-vm-${{ github.run_number }}" - INSTANCE_ZONES: "us-east1-b,us-east1-b" + INSTANCE_ZONES: "${{ secrets.GCP_ZONE }},${{ secrets.GCP_ZONE }}" run: make gcp-vm-instance-stop - name: Delete target GCP VM Instances if: always() run: | gcloud compute instances delete litmus-e2e-first-vm-${{ github.run_number }} litmus-e2e-second-vm-${{ github.run_number }} \ - --zone=us-east1-b \ + --zone=${{ secrets.GCP_ZONE }} \ --quiet - name: "[Debug]: check chaos resources" @@ -161,7 +161,7 @@ jobs: run: | gcloud compute instances create litmus-e2e-vm-${{ github.run_number }} \ --machine-type=f1-micro \ - --zone=us-east1-b \ + --zone=${{ secrets.GCP_ZONE }} \ --create-disk name=litmus-e2e-first-disk-${{ github.run_number }},size=1GB \ --create-disk name=litmus-e2e-second-disk-${{ github.run_number }},size=1GB @@ -174,14 +174,14 @@ jobs: env: GCP_PROJECT_ID: ${{ secrets.GCP_PROJECT_ID }} DISK_VOLUME_NAMES: "litmus-e2e-first-disk-${{ github.run_number }},litmus-e2e-second-disk-${{ github.run_number }}" - DISK_ZONES: "us-east1-b,us-east1-b" + DISK_ZONES: "${{ secrets.GCP_ZONE }},${{ secrets.GCP_ZONE }}" run: make gcp-vm-disk-loss - name: Delete the VM Instance and target Disk Volumes if: always() run: | gcloud compute instances delete litmus-e2e-vm-${{ github.run_number }} \ - --zone=us-east1-b \ + --zone=${{ secrets.GCP_ZONE }} \ --delete-disks=all \ --quiet diff --git a/.github/workflows/nightly-m-agent-experiment-pipeline.yaml b/.github/workflows/nightly-m-agent-experiment-pipeline.yaml index 22b2c4ddb..0f2041916 100644 --- a/.github/workflows/nightly-m-agent-experiment-pipeline.yaml +++ b/.github/workflows/nightly-m-agent-experiment-pipeline.yaml @@ -25,7 +25,7 @@ jobs: run: | gcloud compute instances create litmus-e2e-m-agent-vm-${{ github.run_number }} \ --machine-type=f1-micro \ - --zone=us-east4-c \ + --zone=${{ secrets.GCP_ZONE }} \ --metadata=startup-script='#! /bin/bash apt update apt -y install apache2 @@ -35,7 +35,7 @@ jobs: - name: Get Agent Endpoint and Auth Token if: always() id: get-credentials - run: gcloud compute ssh --zone us-east4-c litmus-e2e-m-agent-vm-${{ github.run_number }} -- 'm-agent --get-token --token-expiry-duration 30m' > token.txt + run: gcloud compute ssh --zone ${{ secrets.GCP_ZONE }} litmus-e2e-m-agent-vm-${{ github.run_number }} -- 'm-agent --get-token --token-expiry-duration 30m' > token.txt - uses: actions/upload-artifact@v3 with: @@ -45,12 +45,12 @@ jobs: - name: Get main PID of the Apache Service as Target Process if: always() id: get-apache-target-process - run: echo "::set-output name=pid1::$(gcloud compute ssh --zone us-east4-c litmus-e2e-m-agent-vm-${{ github.run_number }} -- 'systemctl show --property MainPID --value apache2')" + run: echo "::set-output name=pid1::$(gcloud compute ssh --zone ${{ secrets.GCP_ZONE }} litmus-e2e-m-agent-vm-${{ github.run_number }} -- 'systemctl show --property MainPID --value apache2')" - name: Get main PID of the Apache Service as Target Process if: always() id: get-crond-target-process - run: echo "::set-output name=pid2::$(gcloud compute ssh --zone us-east4-c litmus-e2e-m-agent-vm-${{ github.run_number }} -- 'systemctl show --property MainPID --value cron')" + run: echo "::set-output name=pid2::$(gcloud compute ssh --zone ${{ secrets.GCP_ZONE }} litmus-e2e-m-agent-vm-${{ github.run_number }} -- 'systemctl show --property MainPID --value cron')" Process_Kill_Serial_Test: needs: Setup_m-agent @@ -233,5 +233,5 @@ jobs: if: always() run: | gcloud compute instances delete litmus-e2e-m-agent-vm-${{ github.run_number }} \ - --zone=us-east4-c \ + --zone=${{ secrets.GCP_ZONE }} \ --quiet \ No newline at end of file