-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update readme #344
chore: update readme #344
Conversation
Signed-off-by: namkyu1999 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @namkyu1999! Thank you for your proposed changes. However, I would like to avoid putting some third-party image as officially recommended by Litmus maintainers.
I think that we can just refer to the original issue: bitnami/charts#7305 and propose an example how to override the image repository and tag via helm values.
Let me know what do you think about it?
Hi @Jasstkn, Thanks for the comment.
Is this still a non-recommended way? |
I don't want to include in the README recommendation to use specific third-party image. So basically, leave the section with the ARM use-case, add link to the Bitnami issue and add a command like the following: helm install chaos litmuschaos/litmus --namespace=litmus \
--set portal.frontend.service.type=NodePort \
--set mongodb.image.registry=<put_registry> \
--set mongodb.image.repository=<put_image_repository> \
--set mongodb.image.tag=<put_image_tag> |
Signed-off-by: namkyu1999 <[email protected]>
Hi @Jasstkn , ## ARM support
## Litmus helm chart depends on bitnami/mongodb, which uses a mongodb image not supported on ARM.
## To install Litmus on an ARM-based server, use a custom MongoDB ARM image instead of the default.
# helm install chaos litmuschaos/litmus --namespace=litmus \
# --set mongodb.image.registry=<put_registry> \
# --set mongodb.image.repository=<put_image_repository> \
# --set mongodb.image.tag=<put_image_tag> Can you take a look at this one again, please? |
Signed-off-by: namkyu1999 <[email protected]>
Signed-off-by: namkyu1999 <[email protected]>
Signed-off-by: namkyu1999 <[email protected]>
Signed-off-by: namkyu1999 <[email protected]>
@namkyu1999 thank you for the contribution! merged 🚀 |
What this PR does / why we need it:
I updated installation.md for ARM users. Briefly, the official MongoDB Helm chart does not support ARM, so I added commands for users to install Litmus with an unofficial MongoDB image.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]