Integrate the litmus images with scarf gateway #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubham Chaudhary <[email protected]>
ispeakc0de
requested review from
Jasstkn,
ksatchit,
uditgaurav,
chandankumar4,
imrajdas,
ajeshbaby and
gdsoumya
as code owners
ispeakc0de
changed the title
ksatchit
approved these changes
Dec 4, 2023
Signed-off-by: Shubham Chaudhary <[email protected]>
Signed-off-by: Shubham Chaudhary <[email protected]>
Saranya-jena
approved these changes
Dec 4, 2023
uditgaurav
approved these changes
Dec 4, 2023
neelanjan00
approved these changes
Dec 4, 2023
|
Is that deploy chart failure is expected behaviour? |
Shouldn't be/ seems like a CRD install issue that needs to be looked into |
ispeakc0de
force-pushed
the
scarf
branch
8 times, most recently
from
4698cfe to
8d5a097
Compare
Jasstkn
reviewed
Dec 5, 2023
…ons, we can add it later with better testing Signed-off-by: Shubham Chaudhary <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Litmus is making use of Scarf to obtain usage stats (via the docker images) to measure the adoption of the project. This requires adding the scarf gateway prefix to the images in the deployment specs. This PR instruments the Litmus Helm charts with the same.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]