Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Experiment Messages #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor Experiment Messages #15

wants to merge 2 commits into from
+51 −204

Conversation

neelanjan00
Copy link
Member

What this PR does / why we need it: Refactors experiment code for sending messages

Checklist:

  • Fixes #
  • PR messages has document related information
  • Labelled this PR & related issue with breaking-changes tag
  • PR messages has breaking changes related information
  • Labelled this PR & related issue with requires-upgrade tag
  • PR messages has upgrade related information
  • Commit has unit tests
  • Commit has integration tests
  • E2E run Required for the changes

@neelanjan00 neelanjan00 added the enhancement New feature or request label Jun 23, 2022
@neelanjan00 neelanjan00 requested a review from avaakash June 23, 2022 10:46
@neelanjan00 neelanjan00 self-assigned this Jun 23, 2022
avaakash
avaakash approved these changes Jun 23, 2022
View reviewed changes
Copy link

@avaakash avaakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;
This PR is in reference to the comment: #6 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksatchit ksatchit ksatchit approved these changes

@avaakash avaakash avaakash approved these changes

Assignees

@neelanjan00 neelanjan00

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neelanjan00 @avaakash @ksatchit