-
Notifications
You must be signed in to change notification settings - Fork 61
[ENHANCEMENT REQUEST] - Add SIP Participant SIP endpoint status code on participant_joined & participant_disconnected events #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I really think this would be the best details we could get for a SIP workflow. |
I also agree with this. Currently, when creating a SIP participant, it is immediately added to the room regardless of whether the participant has answered the call or not. This is not very rigorous in actual business scenarios. I hope that trigger events for such scenarios can be added to facilitate users in better implementing their business logic. |
@hu-kang No I'm not saying that and actually the SIP participant event flow is well detailed : https://docs.livekit.io/sip/sip-participant/#sip-attributes But we don't have the sip status code granularity for errors or failure. |
Sorry, I misunderstood. The situation I encountered was that when creating an SIP participant, the participant did not answer the call but was already added to the room, and we could not capture the event of the missed call. |
@hu-kang Actually you can with infer status with
|
Please just add sip status code to the webhook and room event we receive when a SIP participant join or disconnect so we could behave on our SIP endpoints as we want without relying solely on Livekit events. For example you could add "sip_status_code" on participant_joined and disconnected events if it's a SIP participant.
For production use case we want to infer deeply on the SIP status code to modify our workflow and take decision. Not only if participant has "SIP_TRUNK_FAILURE", while this disconnect_reason is never reachable from room events.
The text was updated successfully, but these errors were encountered: