Skip to content

Create global chai setup #572

@RiccardoBiosas

Description

@RiccardoBiosas

Context
Currently chai is directly imported on each test file, where it is then attached to the ethereum-waffle's solidity chai matcher (i.e.: here). Furthermore, there are occurrences where it uses different assertion styles (i.e.: here and here).

TODO

  • Create a global chai setup in its own separate file
  • Replace ethereum-waffle with chai-ethers: the ethereum-waffle library is much broader in its scope than chai-ethers which, similarly to ethereum-waffle's solidity, only provides chai matchers to deal with ethereum testing. Removing ethereum-waffle will prevent potential misuse in the future should anyone use it for anything else other than attaching its matchers to chai.
  • Enforce a consistent assertion style: since it seems that the most used construct is expect, we should remove all the occurrences of assert
  • add expectThrow and expectFail as custom assertions in the custom chai setup

Related to #566

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions