Adjust volume does not work?

[edwardlee23]

The filename is *.mp4, and the volume is set to 0.0:
When I use ffmpeg.input(filename).audio.volume(volume=volume), the final output seems to retain the original volume. However, after setting the volume as a string: "0.0", it mutes as expected.

I noticed the ignore_default comment: Convert the values of the dictionary to strings., but it actually converts them to a tuple of objects.

typed-ffmpeg/src/ffmpeg/utils/run.py

Lines 21 to 27 in 4f4c456

	def ignore_default(
	kwargs: dict[str, str | int | float | bool | Default]
	) -> tuple[tuple[str, str | int | float | bool | LazyValue], ...]:
	"""
	Convert the values of the dictionary to strings.
	"""
	return tuple((k, v) for k, v in kwargs.items() if not isinstance(v, Default))

Is this a bug, or am I misusing it? Thanks.

[edwardlee23]

Update:
When I set the volume to 0.1, it still works correctly without needing to cast it to a string.

[lucemia]

@edwardlee23 I couldn’t reproduce this issue. Here’s how I attempted to replicate it. If the issue persists, could you check the compiled command?

https://github.com/livingbio/typed-ffmpeg/pull/436/files

[edwardlee23]

Oh, sorry I found the problem. It's not a bug happended in this package.
Because I check volume using if volume. 0.0 is False, and "0.0" is True...

volume = opt.pop("volume", None)
if volume:
    stream = stream.volume(volume=volume)