Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code questions.. or Typos? #11

Open
denniswittich opened this issue Feb 13, 2018 · 1 comment
Open

Code questions.. or Typos? #11

denniswittich opened this issue Feb 13, 2018 · 1 comment

Comments

@denniswittich
Copy link

denniswittich commented Feb 13, 2018

These two questions came up, when I went threw the code:

  • In line 127 of pokeGan.py the bn1 tensor is created. But actually it is never used.. instead the next line continues with lrelu(conv1,...). Any reason for that?

  • Why is tanh used to generate the final images (line 113). Shouldn't the images values be between 0 and 1? So would not the sigmoid activation be the better choice here?

Any answers / ideas?

@todd-koeck
Copy link

I have the same question about bn1, but I think its just left over from a cut-n-paste as the generator has the same code.

I could be completely wrong on this though as I didn't get good results on the included pokemon images nor am I getting much better results on some other data I've thrown at it. I believe GAN networks take a lot of time and data to train, so there might just be a need to train more, or there could be problems in the code.

On tanh vs. sigmoid, I understand (in my very limited knowledge) that tanh trains better in many cases than sigmoid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants