Skip to content

Commit 1e89355

Browse files
authored
[clang-format] Treat f<N | M>(a) as template function call (#124438)
Fixes #123144.
1 parent 44c9e46 commit 1e89355

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

clang/lib/Format/TokenAnnotator.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -252,10 +252,10 @@ class AnnotatingParser {
252252
// parameters.
253253
// FIXME: This is getting out of hand, write a decent parser.
254254
if (MaybeAngles && InExpr && !Line.startsWith(tok::kw_template) &&
255-
Prev.is(TT_BinaryOperator)) {
256-
const auto Precedence = Prev.getPrecedence();
257-
if (Precedence > prec::Conditional && Precedence < prec::Relational)
258-
MaybeAngles = false;
255+
Prev.is(TT_BinaryOperator) &&
256+
(Prev.isOneOf(tok::pipepipe, tok::ampamp) ||
257+
Prev.getPrecedence() == prec::Equality)) {
258+
MaybeAngles = false;
259259
}
260260
if (Prev.isOneOf(tok::question, tok::colon) && !Style.isProto())
261261
SeenTernaryOperator = true;

clang/unittests/Format/TokenAnnotatorTest.cpp

+6-1
Original file line numberDiff line numberDiff line change
@@ -692,7 +692,7 @@ TEST_F(TokenAnnotatorTest, UnderstandsNonTemplateAngleBrackets) {
692692
EXPECT_TOKEN(Tokens[4], tok::less, TT_BinaryOperator);
693693
EXPECT_TOKEN(Tokens[8], tok::greater, TT_BinaryOperator);
694694

695-
Tokens = annotate("return A < B ^ A > B;");
695+
Tokens = annotate("return A < B != A > B;");
696696
ASSERT_EQ(Tokens.size(), 10u) << Tokens;
697697
EXPECT_TOKEN(Tokens[2], tok::less, TT_BinaryOperator);
698698
EXPECT_TOKEN(Tokens[6], tok::greater, TT_BinaryOperator);
@@ -3678,6 +3678,11 @@ TEST_F(TokenAnnotatorTest, TemplateInstantiation) {
36783678
EXPECT_TOKEN(Tokens[2], tok::less, TT_TemplateOpener);
36793679
EXPECT_TOKEN(Tokens[6], tok::greater, TT_TemplateCloser);
36803680

3681+
Tokens = annotate("return FixedInt<N | M>(foo);");
3682+
ASSERT_EQ(Tokens.size(), 12u) << Tokens;
3683+
EXPECT_TOKEN(Tokens[2], tok::less, TT_TemplateOpener);
3684+
EXPECT_TOKEN(Tokens[6], tok::greater, TT_TemplateCloser);
3685+
36813686
Tokens = annotate("return std::conditional_t<T::value == U::value, T, U>{};");
36823687
ASSERT_EQ(Tokens.size(), 21u) << Tokens;
36833688
EXPECT_TOKEN(Tokens[4], tok::less, TT_TemplateOpener);

0 commit comments

Comments
 (0)