Skip to content

[mlir][test] Add missing REQUIRES: asserts for --debug-only flag #149634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2025

Conversation

rupprecht
Copy link
Collaborator

Debug flags are not provided in fully optimized builds.

Test added in #149378 / #146228

@rupprecht rupprecht requested a review from j2kun July 19, 2025 02:54
@llvmbot llvmbot added the mlir label Jul 19, 2025
@llvmbot
Copy link
Member

llvmbot commented Jul 19, 2025

@llvm/pr-subscribers-mlir

Author: Jordan Rupprecht (rupprecht)

Changes

Debug flags are not provided in fully optimized builds.

Test added in #149378 / #146228


Full diff: https://github.com/llvm/llvm-project/pull/149634.diff

1 Files Affected:

  • (modified) mlir/test/IR/test-pattern-logging-listener.mlir (+1)
diff --git a/mlir/test/IR/test-pattern-logging-listener.mlir b/mlir/test/IR/test-pattern-logging-listener.mlir
index e8f0d61a75960..c521110a87aa3 100644
--- a/mlir/test/IR/test-pattern-logging-listener.mlir
+++ b/mlir/test/IR/test-pattern-logging-listener.mlir
@@ -1,3 +1,4 @@
+// REQUIRES: asserts
 // RUN: mlir-opt %s --test-walk-pattern-rewrite-driver \
 // RUN:   --allow-unregistered-dialect --debug-only=pattern-logging-listener 2>&1 | FileCheck %s
 

@rupprecht rupprecht merged commit e1ac57c into llvm:main Jul 19, 2025
10 of 11 checks passed
@rupprecht
Copy link
Collaborator Author

Landed to get builds green again, and IMO this is fairly trivial. Lemme know if you have any comments.

@joker-eph
Copy link
Collaborator

Thanks for the fix!

The underlying issue is that we should not use the debug output in a test though, I'll follow up on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants