Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 build: add .nvmrc file with LTS version #622

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

Asuka109
Copy link
Contributor

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

🔀 变更说明 | Description of Change

Add .nvmrc file to setup Node.js with fnm automatically.

Refer to: https://github.com/Schniz/fnm?tab=readme-ov-file#shell-setup

📝 补充信息 | Additional Information

Copy link

vercel bot commented Dec 12, 2023

@Asuka109 is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @Asuka109

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9616783) 85.59% compared to head (db246f1) 85.59%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #622   +/-   ##
=======================================
  Coverage   85.59%   85.59%           
=======================================
  Files         166      166           
  Lines        7615     7615           
  Branches      655      655           
=======================================
  Hits         6518     6518           
  Misses       1097     1097           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arvinxx
Copy link
Contributor

arvinxx commented Dec 12, 2023

why 18? not 20?

@lobehub lobehub deleted a comment from lobehubbot Dec 12, 2023
@Asuka109
Copy link
Contributor Author

why 18? not 20?

Just never try that. Do you think we can use lts/iron?

Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 3:47pm

@arvinxx
Copy link
Contributor

arvinxx commented Dec 12, 2023

why 18? not 20?

Just never try that. Do you think we can use lts/iron?

I’m not sure, but the PR say "with LTS version"

by now the LTS is 20

image

@Asuka109
Copy link
Contributor Author

@arvinxx Node.js 18 is one of the lts versions and will be supported as a long-term version until April 2025.

It appears you're not very experienced with using version 20 either. How about setting it to 18 for now?

https://nodejs.org/en/about/previous-releases#release-schedule
image

@arvinxx
Copy link
Contributor

arvinxx commented Dec 13, 2023

Ok

@arvinxx arvinxx merged commit ad8dd19 into lobehub:main Dec 13, 2023
6 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @Asuka109 ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

@lobehubbot
Copy link
Member

🎉 This PR is included in version 0.110.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants