Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit test for src/server/utils/env.ts #5930

Closed
wants to merge 3 commits into from

Conversation

gru-agent[bot]
Copy link
Contributor

@gru-agent gru-agent bot commented Feb 9, 2025

Trigger Info

Trigger Type Triggered By Source Pull Request Assignment
PR Created fzlzjerry 5927 Detail

Summary

This PR introduces unit tests for the env utility functions to ensure their correctness and reliability. The following tests are included:

  • getEnvironment function:

    • Verifies it returns an empty string when process is undefined.

    • Confirms it returns an empty string for non-existent environment variables.

    • Ensures it retrieves the correct value for existing environment variables.

  • isDev function:

    • Validates that it returns true when NODE_ENV is set to development.

    • Confirms it returns false when NODE_ENV is set to production.

  • isOnServerSide function:

    • Ensures it returns true when window is undefined (indicating server-side execution).

    • Verifies it returns false when window is defined (indicating client-side execution).

The tests utilize vitest for mocking and assertions, and proper cleanup is performed after each test to avoid side effects.

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

Tip

You can @gru-agent rebase to rebase the PR.

Tip

You can @gru-agent redo to reset or rebase before redoing the PR.

Tip

To modify the test code yourself, click here Edit Test Code

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 9, 2025
@lobehubbot
Copy link
Member

👍 @gru-agent[bot]

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.15%. Comparing base (4108795) to head (a206191).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5930      +/-   ##
==========================================
+ Coverage   92.13%   92.15%   +0.02%     
==========================================
  Files         650      651       +1     
  Lines       59068    59253     +185     
  Branches     4086     2732    -1354     
==========================================
+ Hits        54421    54606     +185     
  Misses       4647     4647              
Flag Coverage Δ
app 92.15% <100.00%> (+0.02%) ⬆️
server 98.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

vercel bot commented Feb 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 6:48am

@arvinxx arvinxx closed this Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants