Skip to content

fix custom onnxruntime version #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025

Conversation

fritz-fritz
Copy link
Contributor

Introduced a new variable so that built libraries appropriately reflect the custom onnxruntime version.
Also added a symlink from libonxruntime.so.1

The real benefit of this is seen when leveraging CMakeUserPresets as shown in my gist here that addresses #591.

This pull request does not update the default onnxruntime versions or integrate with the installer scripts.

Introduced a new variable so that built libraries appropriately reflect the custom onnxruntime version.
Also added a symlink from libonxruntime.so.1
@royshil
Copy link
Owner

royshil commented Apr 1, 2025

@fritz-fritz can you run cmake-format on cmake/FetchOnnxruntime.cmake plz?

Aligned file with defined formatting per `./build-aux/run-cmake-format --fail-error`
@fritz-fritz
Copy link
Contributor Author

@royshil Should be good to go now ✔️

Copy link
Owner

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@royshil royshil merged commit b86bf8b into royshil:main Apr 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants