Skip to content

Commit

Permalink
fix/POD 837 remove fallback cloning (#1232)
Browse files Browse the repository at this point in the history
* fix(cli): only setup platform access if we're using pro provider to create
workspace

* fix(cli): remove local clone fallback

Removes the current behaviour of falling back to a local clone and
upload to VM/Pod afterwards. Over the course of the last year we've
found it is more confusing than it helps.
Instead, this PR improves the logs when cloning on the remote fails to
allow users to address the root cause better.
  • Loading branch information
pascalbreuninger authored Aug 31, 2024
1 parent 1d4e463 commit cc1dbc9
Show file tree
Hide file tree
Showing 8 changed files with 361 additions and 267 deletions.
4 changes: 2 additions & 2 deletions cmd/agent/workspace/install_dotfiles.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ func (cmd *InstallDotfilesCmd) Run(ctx context.Context) error {
logger.Infof("Cloning dotfiles %s", cmd.Repository)

gitInfo := git.NormalizeRepositoryGitInfo(cmd.Repository)
err = git.CloneRepository(ctx, gitInfo, targetDir, "", false, nil, logger.Writer(logrus.DebugLevel, false), logger)
if err != nil {

if err := git.CloneRepository(ctx, gitInfo, targetDir, "", nil, logger); err != nil {
return err
}
} else {
Expand Down
Loading

0 comments on commit cc1dbc9

Please sign in to comment.