Skip to content

Commit cc1dbc9

Browse files
fix/POD 837 remove fallback cloning (#1232)
* fix(cli): only setup platform access if we're using pro provider to create workspace * fix(cli): remove local clone fallback Removes the current behaviour of falling back to a local clone and upload to VM/Pod afterwards. Over the course of the last year we've found it is more confusing than it helps. Instead, this PR improves the logs when cloning on the remote fails to allow users to address the root cause better.
1 parent 1d4e463 commit cc1dbc9

File tree

8 files changed

+361
-267
lines changed

8 files changed

+361
-267
lines changed

cmd/agent/workspace/install_dotfiles.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ func (cmd *InstallDotfilesCmd) Run(ctx context.Context) error {
5151
logger.Infof("Cloning dotfiles %s", cmd.Repository)
5252

5353
gitInfo := git.NormalizeRepositoryGitInfo(cmd.Repository)
54-
err = git.CloneRepository(ctx, gitInfo, targetDir, "", false, nil, logger.Writer(logrus.DebugLevel, false), logger)
55-
if err != nil {
54+
55+
if err := git.CloneRepository(ctx, gitInfo, targetDir, "", nil, logger); err != nil {
5656
return err
5757
}
5858
} else {

0 commit comments

Comments
 (0)