-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Open
Description
Hello,
The method Lightbox.prototype.sizeOverlay
returns nothing, but here the return value is used:
this.$lightbox.find('.lb-dataContainer').fadeIn(this.options.resizeDuration, function() {
return self.sizeOverlay();
});
It doesn't seem like a bug, but it's still probably worth correcting.
Another piece of code struck me as odd:
this.$outerContainer.on('click', function(event) {
if ($(event.target).attr('id') === 'lightbox') {
self.end();
}
return false;
});
The outerContainer element is a descendant of the lightbox element, so checking id will always return false. I don't know jQuery very well, so I could be wrong. Sorry then.
Metadata
Metadata
Assignees
Labels
No labels