-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emojis no longer rendered properly in the comments #126
Comments
|
hm, maybe some changes to how automatic comments are treated? |
Editing around in another comment shows that they are rendered again when the leading html space is removed:
|
Still an issue r-lib/styler#1189 (comment) and in comment above Probably just needs as space to make it work ? or maybe styler has not updated its workflows? |
Also don’t geht that. Styler seems to use the main tag, so it should use the latest commit on main: https://github.com/r-lib/styler/blob/208d9c7abb4eb44436695a68a19ea979c99ce921/.github/workflows/touchstone-comment.yaml#L20 However, I still see the ballot_box_with_check.. but the PR #127 changed that so I am confused. Do we need to release a new tag? |
In this repo the emojis show up fine: kgoldfeld/simstudy#221 (comment) |
https://github.com/lorenzwalthert/touchstone/blob/main/actions/receive/action.yaml#L103 Sorry, I didn't think of that when we merged the fixes. |
Ok, so should we create a new tag and move the default? I guess no one would want to use |
Usually for actions you would tag |
Great. Can you do that? |
Done, that should propagate the fix to styler! |
It has, thanks a lot! |
E.g. r-lib/styler#1173 (comment)
The text was updated successfully, but these errors were encountered: