Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library should support non json messages too #52

Open
assadvirgo opened this issue Oct 30, 2018 · 1 comment
Open

library should support non json messages too #52

assadvirgo opened this issue Oct 30, 2018 · 1 comment

Comments

@assadvirgo
Copy link
Contributor

with the current version, library test for the json messages and if its not a valid json it simply throws the error. However if we want to subscribe to events like "expired" they don't return a json object.
@RangerMauve
Copy link
Collaborator

Good point!

A PR with unit tests would be very much welcome for this change. 😀

gdelory added a commit to gdelory/node-redis-pubsub that referenced this issue Dec 17, 2020
@gdelory
Update to redis 3
b0d44e3 
louischatriot#52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RangerMauve @assadvirgo