Skip to content

Commit 4e89a66

Browse files
timothytrippelpamaury
authored andcommitted
[orchestrator] fix bug in device ID update
If CP flow is skipped because a device is already in TEST_LOCKED* state, then the device ID constructed during FT will be the final device ID. This is what should be used to update the database with. Signed-off-by: Tim Trippel <[email protected]> (cherry picked from commit 76d0596)
1 parent 9dda62d commit 4e89a66

File tree

1 file changed

+3
-1
lines changed
  • sw/host/provisioning/orchestrator/src

1 file changed

+3
-1
lines changed

sw/host/provisioning/orchestrator/src/ot_dut.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,11 +314,13 @@ def run_ft(self) -> None:
314314
device_id_in_otp = DeviceId.from_hexstr(self.ft_data["device_id"])
315315
if device_id_in_otp != self.device_id:
316316
logging.error(
317-
"Device ID from OTP does not match expected on host.")
317+
"Device ID from OTP does not match expected on host. Use OTP variant?"
318+
)
318319
logging.error(
319320
f"Final (device) DeviceId: {device_id_in_otp.to_hexstr()}")
320321
logging.error(
321322
f"Final (host) DeviceId: {self.device_id.to_hexstr()}")
322323
confirm()
324+
self.device_id = device_id_in_otp
323325

324326
logging.info("FT completed successfully.")

0 commit comments

Comments
 (0)