Possible Unsound Safe API

[charlesxsh]

impl EndpointBuffer {
    pub fn new(offset: usize, size: usize) -> Self {
        let addr = unsafe { EP_MEM_PTR.add(offset) };
        let mem = unsafe { slice::from_raw_parts_mut(addr, size) };
        Self(mem)
    }
}

In public accessible function EndpointBuffer::new, it accepts parameters offset and size and used in pointer calculation and slice creation but lack of sufficient checks, which might cause memory issues. In Rust, we should not cause any memory issues if merely using safe functions.

[allexoll]

thanks! that's indeed very much wrong, I'll gladly accept a PR if you want to take it on (no time on my part).

and you should probably open an issue there: https://github.com/lpc55/lpc55-hal/issues

Since the code mostly come from there and they have the same impl