Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to edit build plans for exam programming exercises #10454

Open
angatha opened this issue Mar 8, 2025 · 2 comments
Open

Impossible to edit build plans for exam programming exercises #10454

angatha opened this issue Mar 8, 2025 · 2 comments
Labels
atlas Pull requests that affect the corresponding module bug exam Pull requests that affect the corresponding module exercise Pull requests that affect the corresponding module programming Pull requests that affect the corresponding module

Comments

@angatha
Copy link

angatha commented Mar 8, 2025

Describe the bug

In 7.10.4, I created an exam and added a programming exercise. I noticed that I cant submit the build plan.

The stripped down request looks like this:

curl 'https://domain.de/api/programming-exercises/undefined/build-plan' \
  -X 'PUT' \
  -H 'Referer: https://domain.de/course-management/3/exams/1/exercise-groups/1/programming-exercises/27/edit-build-plan' \
  -H 'Accept: application/json, text/plain, */*' \
  -H 'Content-Type: application/json' \
  --data-raw xxx

You may note the undefined in the url. This should be the exercise id (27).

I tracked the origin of that id down to build-plan-editor.component.ts. There programmingExercise is set and in loadSolutionAndTemplateParticipation(), the id gets read from there. In a jusual exercise, this listener is called and the id gets initialized. For an exam programming exercise, this does not happen. substribe(...) is called but the callback is never called.

I noticed, that this.activatedRoute.data._value evaluates to an object with keys authorities and pageTitle. A normal programming exercise has additionally course and exercise.

Artemis has the following profiles active: artemis,scheduling,core,prod,docker,jenkins,localvc,atlas,saml2

To Reproduce

  1. Create a new exam
  2. Add an exercise group
  3. Add a programming exercise
  4. Edit build plans
  5. Submit the build plan

Expected behavior

Submit the build plan.

Screenshots

Artemis has the following profiles active: artemis,scheduling,core,prod,docker,jenkins,localvc,atlas,saml2

Which version of Artemis are you seeing the problem on?

7.10.4

What browsers are you seeing the problem on?

Chrome

Additional context

No response

Relevant log output

artemis-app  | 2025-03-08T06:35:01.998Z  WARN 1 --- [Artemis] [-handler-733634] o.z.problem.spring.common.AdviceTraits   : Bad Request: Method parameter 'exerciseId': Failed to convert value of type 'java.lang.String' to required type 'java.lang.Long'; For input string: "undefined"
@angatha angatha added the bug label Mar 8, 2025
@github-actions github-actions bot added atlas Pull requests that affect the corresponding module exam Pull requests that affect the corresponding module exercise Pull requests that affect the corresponding module programming Pull requests that affect the corresponding module labels Mar 8, 2025
@krusche
Copy link
Member

krusche commented Mar 8, 2025

Is this related to build plans for Jenkins or does this also affect LocalCI?

@angatha
Copy link
Author

angatha commented Mar 8, 2025

LocalCI is not enabled and I can not verify that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
atlas Pull requests that affect the corresponding module bug exam Pull requests that affect the corresponding module exercise Pull requests that affect the corresponding module programming Pull requests that affect the corresponding module
Projects
None yet
Development

No branches or pull requests

2 participants