Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Communication: PostDTO should not include entire entity object #9675

Open
PaRangger opened this issue Nov 6, 2024 · 0 comments
Open

Communication: PostDTO should not include entire entity object #9675

PaRangger opened this issue Nov 6, 2024 · 0 comments
Assignees
@PaRangger
Labels
chore code quality communication Pull requests that affect the corresponding module component:Communication exam Pull requests that affect the corresponding module feature iris Pull requests that affect the corresponding module programming Pull requests that affect the corresponding module text Pull requests that affect the corresponding module

Comments

@PaRangger
Copy link
Contributor

Is your feature request related to a problem?

Currently the PostDTO includes the entire entity. This against the best pracitce in the docs and is even used as a negative example there.

Describe the solution you'd like

The DTO should only include the necessary data that has to be sent to the client. Instead of including other entities, it should include DTOs of the other entities (AnswerPosts, Reactions, ...).

Describe alternatives you've considered

No response

Additional context

No response
@PaRangger PaRangger added feature chore code quality component:Communication communication Pull requests that affect the corresponding module labels Nov 6, 2024
@PaRangger PaRangger self-assigned this Nov 6, 2024
@github-actions github-actions bot added exam Pull requests that affect the corresponding module iris Pull requests that affect the corresponding module programming Pull requests that affect the corresponding module text Pull requests that affect the corresponding module labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PaRangger PaRangger

Labels
chore code quality communication Pull requests that affect the corresponding module component:Communication exam Pull requests that affect the corresponding module feature iris Pull requests that affect the corresponding module programming Pull requests that affect the corresponding module text Pull requests that affect the corresponding module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PaRangger