Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] some explicit args in open_tslong, open_tswide, open_tsdf and wrap methods #57

Open
martibosch opened this issue Jul 19, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@martibosch
Copy link
Collaborator

Currently, many methods (see the issue title but I may be forgetting others) accept args and kwargs that are then forwarded to a backend-specific method, e.g., from_tstore. However, some arguments, e.g., time filters, are likely the same in all backends, so we should add them explicitly to the methods' signatures (and add docstrings).

Additionally, I would suggest that we use keyword-only arguments as much as possible, since they enforce good pythonic practices (i.e., explicit better than implicit) and make backwards-compatibility much easier for new releases. Related: #21

@martibosch martibosch added the enhancement New feature or request label Jul 19, 2024
@martibosch martibosch assigned ghiggi and martibosch and unassigned ghiggi Jul 19, 2024
@charlottegiseleweil charlottegiseleweil moved this to In Progress in TSDF PM Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

2 participants