Skip to content

Commit c055401

Browse files
committedOct 3, 2024
add note on redirect uri
1 parent 7c1e43a commit c055401

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed
 

Diff for: ‎README.md

+11-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,13 @@ Uses SQLite. Rate limiting is implemented using JavaScript `Map`.
44

55
## Initialize project
66

7-
Create a GitHub OAuth app. Paste the client ID and secret to a `.env` file.
7+
Create a GitHub OAuth app with the redirect URI pointed to `/login/github/callback`.
8+
9+
```
10+
http://localhost:5173/login/github/callback
11+
```
12+
13+
Paste the client ID and secret to a `.env` file.
814

915
```bash
1016
GITHUB_CLIENT_ID=""
@@ -22,3 +28,7 @@ Run the application:
2228
```
2329
pnpm dev
2430
```
31+
32+
## Notes
33+
34+
- TODO: Update redirect URI

Diff for: ‎src/lib/server/oauth.ts

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { GitHub } from "arctic";
22
import { GITHUB_CLIENT_ID, GITHUB_CLIENT_SECRET } from "$env/static/private";
33

4+
// TODO: Update redirect URI
45
export const github = new GitHub(GITHUB_CLIENT_ID, GITHUB_CLIENT_SECRET, "http://localhost:5173/login/github/callback");

0 commit comments

Comments
 (0)
Please sign in to comment.