Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added shield-user icon #2608

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sebinemeth
Copy link

@sebinemeth sebinemeth commented Nov 12, 2024

closes #2600

What is the purpose of this pull request?

  • New Icon

Description

Added new shield-user icon.

Icon use case

Access to admin area, mark user as admin/elevated access rights

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in Shield-user icon #2600 by @sebinemeth
  • I've based them on the following Lucide icons: shield, user
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Nov 12, 2024
Copy link

github-actions bot commented Nov 12, 2024

Added or changed icons

icons/shield-user.svg

Preview cohesion icons/square-arrow-right.svg
icons/shield-user.svg
icons/package-search.svg
Preview stroke widths icons/shield-user.svg
icons/shield-user.svg
icons/shield-user.svg
DPI Preview (24px) icons/shield-user.svg
Icon X-rays icons/shield-user.svg
Icon Diffs icons/shield-user.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const ShieldUserIcon = createLucideIcon('ShieldUser', [
  ["path",{"d":"M17.116 18a6 6 0 0 0-10.402 0"}],
  ["path",{"d":"M20 13c0 5-3.5 7.5-7.66 8.95a1 1 0 0 1-.67-.01C7.5 20.5 4 18 4 13V6a1 1 0 0 1 1-1c2 0 4.5-1.2 6.24-2.72a1.17 1.17 0 0 1 1.52 0C14.51 3.81 17 5 19 5a1 1 0 0 1 1 1z"}],
  ["circle",{"cx":"12","cy":"11","r":"4"}]
])

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Dec 13, 2024
@jguddas
Copy link
Member

jguddas commented Dec 13, 2024

I would prefer something like this
icons
Open lucide studio

@karsa-mistmere
Copy link
Member

I would prefer something like this iconsOpen lucide studio

Feels a bit imbalanced, maybe a smaller user would be more appropriate:

icons
Open lucide studio

@jguddas
Copy link
Member

jguddas commented Dec 13, 2024

I would prefer something like this iconsOpen lucide studio

Feels a bit imbalanced, maybe a smaller user would be more appropriate:

iconsOpen lucide studio

My version is from the contact-round, and is consistend with circle-user and square-user.
So my vote is for my version, for consistency.

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Dec 13, 2024

My version is from the contact-round, and is consistend with circle-user and square-user. So my vote is for my version, for consistency.

It's not entirely consistent though, since the user shape is 1px lower than in case of circle/square-user.

I feel like even with the minor gap guideline violation this one feels better because it's much less bottom-heavy:

image

icons
Open lucide studio

@jguddas
Copy link
Member

jguddas commented Dec 13, 2024

My version is from the contact-round, and is consistend with circle-user and square-user. So my vote is for my version, for consistency.

It's not entirely consistent though, since the user shape is 1px lower than in case of circle/square-user.

I feel like even with the minor gap guideline violation this one feels better because it's much less bottom-heavy:

image

iconsOpen lucide studio

I'm up for this, even with the gap violation, looks nice.

@github-actions github-actions bot removed the Stale label Dec 14, 2024
@sebinemeth
Copy link
Author

My version is from the contact-round, and is consistend with circle-user and square-user. So my vote is for my version, for consistency.

It's not entirely consistent though, since the user shape is 1px lower than in case of circle/square-user.

I feel like even with the minor gap guideline violation this one feels better because it's much less bottom-heavy:

image

iconsOpen lucide studio

Thanks guys for the contribution, I also like this version, changing now

Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image There are gaps that need to be closed here.

Comment on lines +4 to +5
"sebinemeth",
"ksk3110"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should inherit the contributors from the shield and square-user-round

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shield-user icon
3 participants