fix: add unique keys to iconNode and children to resolve React errors #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericfennis
requested changes
Dec 9, 2024
Co-authored-by: Eric Fennis <[email protected]>
|
@ericfennis Good catch, I applied your suggested changes |
ericfennis
approved these changes
Dec 19, 2024
jguddas
requested changes
Dec 19, 2024
|
@jguddas This is only when custom icons are added. The icon nodes we provide have random keys generated based on the content. |
|
My opinion stays the same, we should not do this. If you want to fix the error add keys to your custom icon data, https://lucide-studio.vercel.app does it automatically already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Description
This PR resolves the missing
keywarnings in theIconcomponent by adding uniquekeyprops to the elements created fromiconNodeandchildren.Closes #2654
Before Submitting