Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Azure Storage #469

Open
yagonobre opened this issue Mar 26, 2018 · 1 comment
Open

Support Azure Storage #469

yagonobre opened this issue Mar 26, 2018 · 1 comment

Comments

@yagonobre
Copy link
Contributor

No description provided.

@Guilhermeslucas
Copy link

Hello everyone, how are you? I'd like to take a look at it it. I just have some questions:

  • The config struct is named with the Aws prefix in all the attributes. Which approach do you think would be better, to change the name to something more generic or to create another struct like AzureCofig?
type Config struct {
	Type                storageType `envconfig:"type" default:"s3"`
	AwsKey              string      `envconfig:"aws_key"`
	AwsSecret           string      `envconfig:"aws_secret"`
	AwsRegion           string      `envconfig:"aws_region"`
	AwsBucket           string      `envconfig:"aws_bucket"`
	AwsEndpoint         string      `envconfig:"aws_endpoint" default:""`
	AwsDisableSSL       bool        `envconfig:"aws_disable_ssl" default:"false"`
	AwsS3ForcePathStyle bool        `envconfig:"aws_s3_force_path_style" default:"false"`
}
  • Looking at the interface that the storage providers should follow, I don't have to much context on what each of the methods should do. Can you give me a little more context on that?
type Storage interface {
	K8sSecretName() string
	AccessData() map[string][]byte
	UploadFile(path string, file io.ReadSeeker) error
	Type() string
	PodEnvVars() map[string]string
	List(path string) ([]*Object, error)
	Delete(path string) error
}

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants