Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry and Healthcheck path without slash does not work #26

Open
ToMe25 opened this issue Jan 20, 2024 · 2 comments
Open

Telemetry and Healthcheck path without slash does not work #26

ToMe25 opened this issue Jan 20, 2024 · 2 comments
Assignees

Comments

@ToMe25
Copy link
Contributor

ToMe25 commented Jan 20, 2024

Using the argument web.telemetry-path or web.healthcheck-path with a path that is not prefixed with a slash results in said page not being reachable at all.
The "Not Found" page still tries to link to it, but said link just leads you to the "Not Found" page again.

In my opinion such a path should be, silently or with a log warning, prepended with a slash.

@ToMe25 ToMe25 changed the title Telemetry and Healthcheck without slash does not work Telemetry and Healthcheck path without slash does not work Jan 20, 2024
@lukasmalkmus
Copy link
Owner

Feel free to tackle this. I'll keep the issues open. But at the moment I don't have capacity to work in this exporter apart from occasional maintenance.

@lukasmalkmus lukasmalkmus removed their assignment Apr 9, 2024
@ToMe25
Copy link
Contributor Author

ToMe25 commented Apr 10, 2024

I opened these recent issues mostly to track these things, I don't consider them to have any significant urgency.

I will look into implementing some of them if and when I find the time and motivation to do so :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants