Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Consistency] Rename --vcgencmd argument to --collector.gpu.vcgencmd #29

Open
ToMe25 opened this issue Jan 20, 2024 · 2 comments
Open
Assignees

Comments

@ToMe25
Copy link
Contributor

ToMe25 commented Jan 20, 2024

I believe the --vcgencmd argument should be renamed to --collector.gpu.vcgencmd or --collector.gpu.vcgencmd-path to be consistent with the node exporter argument naming scheme, which this collector seems to use.

This is because the vcgencmd command is only used for the gpu exporter, and thus not really a general config option.

The big issue with this is, however, that doing so would be a breaking change.

@lukasmalkmus
Copy link
Owner

Feel free to tackle this. I'll keep the issues open. But at the moment I don't have capacity to work in this exporter apart from occasional maintenance.

@ToMe25
Copy link
Contributor Author

ToMe25 commented Apr 10, 2024

I opened these recent issues mostly to track these things, I don't consider them to have any significant urgency.

I will look into implementing some of them if and when I find the time and motivation to do so :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants