Backport RPC timeouts from v3

Author: Matevz Morato

include/depthai/xlink/XLinkStream.hpp

@@ -56,6 +56,7 @@ class XLinkStream {
     void write(const std::uint8_t* data, std::size_t size);
     void write(const std::vector<std::uint8_t>& data);
     std::vector<std::uint8_t> read();
+    std::vector<std::uint8_t> read(std::chrono::milliseconds timeout);
     std::vector<std::uint8_t> read(XLinkTimespec& timestampReceived);
     void read(std::vector<std::uint8_t>& data);
     void read(std::vector<std::uint8_t>& data, XLinkTimespec& timestampReceived);

src/device/DeviceBase.cpp

@@ -49,6 +49,7 @@ const std::string MAGIC_FACTORY_FLASHING_VALUE = "413424129";
 const std::string MAGIC_FACTORY_PROTECTED_FLASHING_VALUE = "868632271";
 
 const unsigned int DEFAULT_CRASHDUMP_TIMEOUT = 9000;
+const unsigned int RPC_READ_TIMEOUT = 30000;
 
 // local static function
 static void getFlashingPermissions(bool& factoryPermissions, bool& protectedPermissions) {
@@ -830,7 +831,7 @@ void DeviceBase::init2(Config cfg, const dai::Path& pathToMvcmd, tl::optional<co
 
             // Receive response back
             // Send to nanorpc to parse
-            return rpcStream->read();
+            return rpcStream->read(std::chrono::milliseconds(RPC_READ_TIMEOUT));
         } catch(const std::exception& e) {
             // If any exception is thrown, log it and rethrow
             pimpl->logger.debug("RPC error: {}", e.what());

src/xlink/XLinkStream.cpp

@@ -192,6 +192,14 @@ bool XLinkStream::write(const std::vector<std::uint8_t>& data, std::chrono::mill
     return write(data.data(), data.size(), timeout);
 }
 
+std::vector<std::uint8_t> XLinkStream::read(std::chrono::milliseconds timeout) {
+    std::vector<std::uint8_t> data;
+    if(!read(data, timeout)) {
+        throw XLinkReadError(X_LINK_TIMEOUT, streamName);
+    }
+    return data;
+}
+
 bool XLinkStream::read(std::vector<std::uint8_t>& data, std::chrono::milliseconds timeout) {
     StreamPacketDesc packet;
     const auto status = XLinkReadMoveDataWithTimeout(streamId, &packet, static_cast<unsigned int>(timeout.count()));