Skip to content

Commit 1f9c2a1

Browse files
committed
fix tests
1 parent ce5b4be commit 1f9c2a1

File tree

2 files changed

+23
-12
lines changed

2 files changed

+23
-12
lines changed

luxonis_ml/data/datasets/luxonis_dataset.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1685,7 +1685,15 @@ def resolve_path(
16851685
str(folder), "zip", root_dir=folder
16861686
)
16871687
archives.append(Path(archive_file))
1688-
return archives if len(archives) > 1 else archives[0]
1688+
if len(archives) > 1:
1689+
logger.info(
1690+
f"Dataset successfully exported to: {[str(p) for p in archives]}"
1691+
)
1692+
return archives
1693+
logger.info(f"Dataset successfully exported to: {archives[0]}")
1694+
return archives[0]
1695+
1696+
logger.info(f"Dataset successfully exported to: {output_path}")
16891697
return output_path
16901698

16911699
def get_statistics(

tests/test_data/test_annotations.py

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -57,16 +57,19 @@ def compare_parquet_rows(
5757
row["file"] = Path(row["file"]) # type: ignore
5858
assert rows == expected_rows
5959

60-
cv2.imwrite(str(tempdir / "left.jpg"), np.zeros((100, 100, 3)))
61-
cv2.imwrite(str(tempdir / "right.jpg"), np.zeros((100, 100, 3)))
62-
record = DatasetRecord(file=tempdir / "left.jpg") # type: ignore
63-
assert record.file == tempdir / "left.jpg"
60+
left = (tempdir / "left.jpg").resolve()
61+
right = (tempdir / "right.jpg").resolve()
62+
63+
cv2.imwrite(str(left), np.zeros((100, 100, 3)))
64+
cv2.imwrite(str(right), np.zeros((100, 100, 3)))
65+
record = DatasetRecord(file=left) # type: ignore
66+
assert record.file == left
6467

6568
compare_parquet_rows(
6669
record,
6770
[
6871
{
69-
"file": tempdir / "left.jpg", # type: ignore
72+
"file": left, # type: ignore
7073
"source_name": "image",
7174
"task_name": "",
7275
"class_name": None,
@@ -78,7 +81,7 @@ def compare_parquet_rows(
7881
)
7982

8083
record = DatasetRecord(
81-
file=tempdir / "left.jpg", # type: ignore
84+
file=left, # type: ignore
8285
annotation={
8386
"class": "person",
8487
"boundingbox": {"x": 0.1, "y": 0.2, "w": 0.3, "h": 0.4},
@@ -88,7 +91,7 @@ def compare_parquet_rows(
8891
record,
8992
[
9093
{
91-
"file": tempdir / "left.jpg", # type: ignore
94+
"file": left, # type: ignore
9295
"source_name": "image",
9396
"task_name": "",
9497
"class_name": "person",
@@ -97,7 +100,7 @@ def compare_parquet_rows(
97100
"annotation": '{"x":0.1,"y":0.2,"w":0.3,"h":0.4}',
98101
},
99102
{
100-
"file": tempdir / "left.jpg", # type: ignore
103+
"file": left, # type: ignore
101104
"source_name": "image",
102105
"task_name": "",
103106
"class_name": "person",
@@ -110,8 +113,8 @@ def compare_parquet_rows(
110113

111114
record = DatasetRecord(
112115
files={
113-
"left": tempdir / "left.jpg",
114-
"right": tempdir / "right.jpg",
116+
"left": left,
117+
"right": right,
115118
}
116119
)
117120
with pytest.raises(ValueError, match="must have exactly one file"):
@@ -578,7 +581,7 @@ def test_record(tempdir: Path):
578581
},
579582
}
580583
)
581-
filename = str(tempdir / "image.jpg")
584+
filename = str((tempdir / "image.jpg").resolve())
582585
cv2.imwrite(filename, np.zeros((256, 256, 3), dtype=np.uint8))
583586
record = DatasetRecord(
584587
file=filename, # type: ignore

0 commit comments

Comments
 (0)