Configured codecov (#174)

Author: kozlov721

.github/labeler.yaml

@@ -19,6 +19,12 @@ tracker:
 CLI:
   - changed-files:
     - any-glob-to-any-file: '**/__main__.py'
+DevOps:
+  - head-branch:
+    - 'devops/*'
+    - 'ci/*'
+  - changed-files:
+    - any-glob-to-any-file: '.github/workflows/ci.yaml'
 release:
   - base-branch: 'main'
 enhancement:

.github/workflows/ci.yaml

@@ -98,48 +98,24 @@ jobs:
         token_format: access_token
 
     - name: Run pytest
-      uses: pavelzw/pytest-action@v2
       env:
         AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
         AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
         AWS_S3_ENDPOINT_URL: ${{ secrets.AWS_S3_ENDPOINT_URL }}
         LUXONISML_BUCKET: luxonis-test-bucket
-      with:
-        emoji: false
-        custom-arguments: --cov luxonis_ml --cov-report xml --junit-xml pytest.xml
+      run:
+        pytest --cov --junitxml=junit.xml -o junit_family=legacy
 
-    - name: Create Test Report
-      uses: EnricoMi/publish-unit-test-result-action@v2
+    - name: Upload test results to Codecov
       if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.8'
+      uses: codecov/test-results-action@v1
       with:
-        files: pytest.xml
+        token: ${{ secrets.CODECOV_TOKEN }}
+        fail_ci_if_error: false
 
-    - name: Generate coverage badge
-      uses: tj-actions/coverage-badge-py@v2
+    - name: Upload coverage results to Codecov
       if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.8'
+      uses: codecov/codecov-action@v4
       with:
-        output: media/coverage_badge.svg
-
-    - name: Generate coverage report
-      uses: orgoro/[email protected]
-      if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.8'
-      with:
-          coverageFile: coverage.xml
-          token: ${{ secrets.GITHUB_TOKEN }}
-
-    - name: Commit coverage badge
-      if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.8'
-      run: |
-        git config --global user.name 'GitHub Actions'
-        git config --global user.email '[email protected]'
-        git diff --quiet media/coverage_badge.svg || {
-          git add media/coverage_badge.svg
-          git commit -m "[Automated] Updated coverage badge"
-        }
-
-    - name: Push changes
-      uses: ad-m/github-push-action@master
-      if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.8'
-      with:
-        branch: ${{ github.head_ref }}
-
+        token: ${{ secrets.CODECOV_TOKEN }}
+        fail_ci_if_error: false

CONTRIBUTING.md

@@ -46,7 +46,7 @@ We use [pytest](https://docs.pytest.org/en/stable/) for testing.
 The tests are located in the `tests` directory. You can run the tests locally with:
 
 ```bash
-pytest tests --cov=luxonis_ml
+pytest tests --cov
 ```
 
 This command will run all tests and print a coverage report. The coverage report
@@ -62,7 +62,7 @@ The tests are run only if the pre-commit hook and documentation build pass.
 Successful tests are required for merging a PR.
 
 1. Checks and tests are run automatically when you open a pull request.
-1. For the tests to run, the [pre-commit](#pre-commit-hooks) hook must pass and
+1. For the tests to run, the [pre-commit](#pre-commit-hooks) hook must pass, and
    the [documentation](#documentation) must be built successfully.
 1. Review the GitHub Actions output if your PR fails.
 1. Fix any issues to ensure that all checks and tests pass.
@@ -72,10 +72,6 @@ Successful tests are required for merging a PR.
 1. Make changes in a new branch.
 1. Test your changes locally.
 1. Commit (pre-commit hook will run).
-1. Push to your branch and create a pull request. Always request a review from:
-   - [Martin Kozlovský](https://github.com/kozlov721)
-   - [Klemen Skrlj](https://github.com/klemen1999)
-   - [Matija Teršek](https://github.com/tersekmatija)
-   - [Conor Simmons](https://github.com/conorsim)
+1. Push to your branch and create a pull request.
 1. Any other relevant team members can be added as reviewers as well.
 1. The team will review and merge your PR.

README.md

@@ -6,7 +6,7 @@
 [![PyPI - Downloads](https://img.shields.io/pypi/dm/luxonis-ml)](https://pypi.org/project/luxonis-ml/)
 
 ![CI](https://github.com/luxonis/luxonis-ml/actions/workflows/ci.yaml/badge.svg)
-![Coverage](https://github.com/luxonis/luxonis-ml/blob/dev/media/coverage_badge.svg)
+[![codecov](https://codecov.io/gh/luxonis/luxonis-ml/graph/badge.svg?token=01E7QTYXWU)](https://codecov.io/gh/luxonis/luxonis-ml)
 
 [![Ruff](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/astral-sh/ruff/main/assets/badge/v2.json)](https://github.com/astral-sh/ruff)
 [![Docformatter](https://img.shields.io/badge/%20formatter-docformatter-fedcba.svg)](https://github.com/PyCQA/docformatter)

luxonis_ml/data/datasets/luxonis_dataset.py

@@ -522,6 +522,8 @@ def add(self, generator: DatasetIterator, batch_size: int = 1_000_000) -> Self:
 
     def _warn_on_duplicates(self) -> None:
         df = self._load_df_offline(lazy=True)
+        if df is None:
+            return
         # Warn on duplicate UUIDs
         duplicates_paired = (
             df.group_by("uuid")
@@ -541,7 +543,7 @@ def _warn_on_duplicates(self) -> None:
         # Warn on duplicate annotations
         duplicate_annotation = (
             df.group_by(["file", "annotation"])
-            .agg(pl.count().alias("count"))
+            .agg(pl.len().alias("count"))
             .filter(pl.col("count") > 1)
         )
         duplicate_annotation_df = duplicate_annotation.collect()

luxonis_ml/nn_archive/config_building_blocks/base_models/input.py

@@ -84,6 +84,9 @@ class Input(BaseModelExtraForbid):
     def validate_layout(self) -> Self:
         self.layout = self.layout.upper()
 
+        if len(self.layout) != len(set(self.layout)):
+            raise ValueError("Layout must not contain duplicate letters.")
+
         if len(self.layout) != len(self.shape):
             raise ValueError("Layout and shape must have the same length.")
 

pyproject.toml

@@ -83,6 +83,9 @@ ignore_missing_imports = true
 [tool.pyright]
 typeCheckingMode = "basic"
 
+[tool.pytest.ini_options]
+addopts = "--disable-warnings"
+
 [tool.coverage.run]
 omit = [
     "luxonis_ml/embeddings/*",

tests/test_data/test_annotations.py

@@ -1,5 +1,3 @@
-import pytest
-
 from luxonis_ml.data.datasets.utils import add_generator_wrapper, rescale_values
 
 
@@ -85,7 +83,3 @@ def dummy_generator():
         tasks.append(record["annotation"]["task"])
 
     assert sorted(tasks) == ["people-boundingbox", "people-keypoints"]
-
-
-if __name__ == "__main__":
-    pytest.main(["-v", "--tb=short"])

tests/test_data/test_dataset.py

@@ -179,7 +179,6 @@ def generator():
 
     with pytest.raises(ValueError):
         dataset.set_skeletons()
-        dataset.add(generator())
 
 
 @pytest.mark.dependency(name="test_dataset[BucketStorage.LOCAL]")
@@ -198,8 +197,7 @@ def _raise(*_):
 
     loader._load_image_with_annotations = _raise
     with pytest.raises(IndexError):
-        for _ in loader:
-            pass
+        _ = loader[0]
 
 
 @pytest.mark.parametrize(
@@ -269,11 +267,21 @@ def generator(step=15):
 
     with pytest.raises(ValueError):
         dataset.make_splits()
+
+    with pytest.raises(ValueError):
         dataset.make_splits((0.7, 0.1, 1))
+
+    with pytest.raises(ValueError):
         dataset.make_splits((0.7, 0.1, 0.1, 0.1))  # type: ignore
+
+    with pytest.raises(ValueError):
         dataset.make_splits((0.7, 0.1, 1), definitions=definitions)
+
+    with pytest.raises(ValueError):
         dataset.make_splits({"train": 1.5})
-        dataset.make_splits({split: defs * 2 for split, defs in definitions.items()})
+
+    with pytest.raises(ValueError):
+        dataset.make_splits({split: defs * 2 for split, defs in splits.items()})
 
     dataset.add(generator(10))
     dataset.make_splits({"custom_split": 1.0})

tests/test_nn_archive/test_nn_archive.py

@@ -160,20 +160,26 @@ def test_layout():
                 "layout": "1chwc2",
             }
         )
+
+    with pytest.raises(ValidationError):
         Input(
             **{
                 **default,
                 "shape": [1, 3, 256, 256],
                 "layout": "nch",
             }
         )
+
+    with pytest.raises(ValidationError):
         Input(
             **{
                 **default,
                 "shape": [1, 3, 256, 256],
                 "layout": "nchh",
             }
         )
+
+    with pytest.raises(ValidationError):
         Output(
             **{
                 "name": "output",
@@ -182,6 +188,8 @@ def test_layout():
                 "layout": "ncn",
             }
         )
+
+    with pytest.raises(ValidationError):
         Output(
             **{
                 "name": "output",